WIP: Fixing the estimated saved time in the gradle wrapper upgrade #4854
+682
−415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moving the change to the markers to a different recipe which returns 0m as the estimated saved time
lkerford
force-pushed
the
fixing-saved-time-gradle-wrapper
branch
from
999b209 to
d3ae411
Compare
lkerford
commented
Jan 6, 2025
| String gradleWrapperVersion = getGradleWrapper(ctx).getVersion(); | ||
| VersionComparator versionComparator = requireNonNull(Semver.validate(isBlank(version) ? "latest.release" : version, null).getValue()); | ||
| int compare = versionComparator.compare(null, currentMarker.getVersion(), currentMarker.withVersion(gradleWrapperVersion).getVersion()); | ||
| if (compare > 0) { |
There was a problem hiding this comment.
Both the UpdateGradleWrapperFiles and UpdateGradleWrapperMarkers class have to run this check to avoid doing duplicate work. I'd prefer to move this into the UpdateGradleWrapper, but I'm uncertain if we can do that
| } | ||
|
|
||
| @Override | ||
| public String getDescription() { |
There was a problem hiding this comment.
For the name and description of this class, I'm not certain how to different it in a meaningful way to users you aren't familiar with the implementation. Is there a way we can add the recipes to the jar but not have the available to be executed directly?
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| } | ||
| }; | ||
| } | ||
| } |
There was a problem hiding this comment.
Suggested change
| } | |
| } |
| } | ||
| }; | ||
| } | ||
| } |
There was a problem hiding this comment.
Suggested change
| } | |
| } |
| } | ||
| }; | ||
| } | ||
| } |
There was a problem hiding this comment.
Suggested change
| } | |
| } |
sambsnyd
reviewed
Jan 7, 2025
Comment on lines
+116
to
+120
| * @return Zero estimated time. | ||
| */ | ||
| @Override | ||
| public Duration getEstimatedEffortPerOccurrence() { | ||
| return Duration.ofMinutes(10); |
There was a problem hiding this comment.
Comment says 0, code says 10 minutes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Do not take into consideration changes which are made is association with updating the markers.
What's your motivation?
Currently the saved time in the Gradle wrapper recipe much larger than it should be