Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use @org.jspecify.annotations.NonNull for @org.openrewrite.internal.lang.NonNull instead of @javax.annotation.Nonnull #4820

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

izeye
Copy link
Contributor

@izeye izeye commented Dec 30, 2024

What's changed?

@timtebeek timtebeek changed the title Polish gh-4415 Use @org.jspecify.annotations.NonNull for @org.openrewrite.internal.lang.NonNull instead of @javax.annotation.Nonnull Dec 30, 2024
Copy link
Contributor

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noticing and applying this change @izeye! I do recall seeing issues with

public class EmptyBlockStyle implements Style {
@NonNull
BlockPolicy blockPolicy;

and
public class OperatorWrapStyle implements Style {
/**
* Whether to add a newline for the token at the end of the line.
*/
@NonNull
WrapOption wrapOption;

which are the last two to use our internal @NonNull annotation changed here. Those changes had previously been reverted in 0805fefa. That means we'll likely need to keep a closer eye on this after a merge, which is then perhaps best merged when everyone's back to work next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready to Review
Development

Successfully merging this pull request may close these issues.

2 participants