Fix PMD rule `LiteralsFirstInComparisons` for `compareTo*` and `contentEquals` #448

pankratz76 · 2025-01-23T21:08:29Z

Fix PMD rule LiteralsFirstInComparisons for compareTo* and contentEquals #362

pankratz76 · 2025-01-23T21:11:07Z

I need to fix my setup to get this running. It should be almost there, right? I think it's better to deliver something now rather than waiting longer. Feel free to take over and provide early feedback if this seems like the right direction. Thanks

…ns-for-compareTo-and-contentEquals' into Fix-PMD-rule-LiteralsFirstInComparisons-for-compareTo-and-contentEquals

pankratz76

feel free to takeover and give feedback, thx.

src/main/java/org/openrewrite/staticanalysis/EqualsAvoidsNull.java

src/test/java/org/openrewrite/staticanalysis/EqualsAvoidsNullTest.java

…compareTo-and-contentEquals

timtebeek · 2025-02-07T09:58:46Z

src/test/java/org/openrewrite/staticanalysis/EqualsAvoidsNullTest.java

+              public class A {
+                  {
+                      String s = null;
+                      if(s.compareTo("test")) {}


I'm wondering if we should add & then invert any comparison with < 0 here for instance, as indicated in #362 (comment). As it stands I think we're using an int in an if. 😕

If we decide to keep the flip for compareTo, we have to also migrate the comparison. Otherwise, we would also flip the semantic, see #442.

ATM, the implementation exclude the flip of < and > needed for compareTo, this can be done later.

src/main/java/org/openrewrite/staticanalysis/EqualsAvoidsNull.java

…compareTo-and-contentEquals # Conflicts: # src/main/java/org/openrewrite/staticanalysis/EqualsAvoidsNullVisitor.java

github-actions

Some suggestions could not be made:

src/main/java/org/openrewrite/staticanalysis/EmptyBlock.java
- lines 19-19
src/main/java/org/openrewrite/staticanalysis/FallThrough.java
- lines 19-19
src/main/java/org/openrewrite/staticanalysis/FinalizeMethodArguments.java
- lines 20-20

github-actions

Some suggestions could not be made:

src/main/java/org/openrewrite/staticanalysis/EmptyBlock.java
- lines 19-19
src/main/java/org/openrewrite/staticanalysis/FallThrough.java
- lines 19-19
src/main/java/org/openrewrite/staticanalysis/FinalizeMethodArguments.java
- lines 20-20

github-actions

Some suggestions could not be made:

src/main/java/org/openrewrite/staticanalysis/EmptyBlock.java
- lines 19-19
src/main/java/org/openrewrite/staticanalysis/FallThrough.java
- lines 19-19
src/main/java/org/openrewrite/staticanalysis/FinalizeMethodArguments.java
- lines 20-20

pankratz76 · 2025-02-09T14:23:54Z

deepseek managed to inline while chatGPT failed ^^

github-actions

Some suggestions could not be made:

src/main/java/org/openrewrite/staticanalysis/EmptyBlock.java
- lines 19-19
src/main/java/org/openrewrite/staticanalysis/FallThrough.java
- lines 19-19
src/main/java/org/openrewrite/staticanalysis/FinalizeMethodArguments.java
- lines 20-20

src/main/java/org/openrewrite/staticanalysis/EqualsAvoidsNull.java

This reverts commit 74cd190.

github-actions

Some suggestions could not be made:

src/main/java/org/openrewrite/staticanalysis/EmptyBlock.java
- lines 19-19
src/main/java/org/openrewrite/staticanalysis/FallThrough.java
- lines 19-19
src/main/java/org/openrewrite/staticanalysis/FinalizeMethodArguments.java
- lines 20-20

src/main/java/org/openrewrite/staticanalysis/EqualsAvoidsNull.java

timtebeek · 2025-02-09T18:49:19Z

Thanks for the work here @punkratz312 ; The automated suggestions are coming in because there's still differences seen after running the following against your branch: https://docs.openrewrite.org/recipes/recipes/rewrite/openrewriterecipebestpractices
Would you mind applying those changes?

pankratz76 · 2025-02-09T18:56:03Z

of course my friend. done and dusty

pankratz76 · 2025-02-09T19:50:18Z

@timtebeek the auto correction does not work. i applied it once before and wonder why. its. not working. see the. ci. My commit is green. The github action is failing.

checking each commit its failing on compile lvl.

github-actions

Some suggestions could not be made:

src/main/java/org/openrewrite/staticanalysis/EmptyBlock.java
- lines 19-19
src/main/java/org/openrewrite/staticanalysis/FallThrough.java
- lines 19-19
src/main/java/org/openrewrite/staticanalysis/FinalizeMethodArguments.java
- lines 20-20

src/main/java/org/openrewrite/staticanalysis/EqualsAvoidsNull.java

github-actions

Some suggestions could not be made:

src/main/java/org/openrewrite/staticanalysis/EmptyBlock.java
- lines 19-19
src/main/java/org/openrewrite/staticanalysis/FallThrough.java
- lines 19-19
src/main/java/org/openrewrite/staticanalysis/FinalizeMethodArguments.java
- lines 20-20
src/test/java/org/openrewrite/staticanalysis/EqualsAvoidsNullTest.java
- lines 25-26

src/main/java/org/openrewrite/staticanalysis/EqualsAvoidsNull.java

github-actions

Some suggestions could not be made:

src/main/java/org/openrewrite/staticanalysis/EmptyBlock.java
- lines 19-19
src/main/java/org/openrewrite/staticanalysis/FallThrough.java
- lines 19-19
src/main/java/org/openrewrite/staticanalysis/FinalizeMethodArguments.java
- lines 20-20
src/test/java/org/openrewrite/staticanalysis/EqualsAvoidsNullTest.java
- lines 25-26

src/main/java/org/openrewrite/staticanalysis/EqualsAvoidsNull.java

…java Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

github-actions

Some suggestions could not be made:

src/main/java/org/openrewrite/staticanalysis/EmptyBlock.java
- lines 19-19
src/main/java/org/openrewrite/staticanalysis/FallThrough.java
- lines 19-19
src/main/java/org/openrewrite/staticanalysis/FinalizeMethodArguments.java
- lines 20-20
src/test/java/org/openrewrite/staticanalysis/EqualsAvoidsNullTest.java
- lines 25-26

MBoegers

I removed some test that were already covered and merged the two visitors.
Great work!

pinguin3245678 and others added 3 commits December 27, 2024 10:19

form

23ce336

Use new J.SwitchExpression constructor

1f33b73

Use new J.SwitchExpression constructor

b38ff0a

pankratz76 force-pushed the Fix-PMD-rule-LiteralsFirstInComparisons-for-compareTo-and-contentEquals branch from 1f33b73 to b38ff0a Compare January 23, 2025 21:08

Vincent Potucek added 4 commits January 25, 2025 17:26

Merge remote-tracking branch 'f/Fix-PMD-rule-LiteralsFirstInCompariso…

3725b4a

…ns-for-compareTo-and-contentEquals' into Fix-PMD-rule-LiteralsFirstInComparisons-for-compareTo-and-contentEquals

tmp fix invertConditional_compareToIgnoreCase

52676bf

wip

883f9cf

tmp fix

1d3c8de

pankratz76 commented Jan 25, 2025

View reviewed changes

pinguin3245678 added 3 commits February 7, 2025 09:02

move EqualsAvoidsNullVisitor into Recipe

d33d0aa

conduct preconditions

a99ae40

static import

b53e380

pankratz76 requested a review from MBoegers February 7, 2025 08:11

pankratz76 marked this pull request as ready for review February 7, 2025 08:11

Merge branch 'main' into Fix-PMD-rule-LiteralsFirstInComparisons-for-…

decf84b

…compareTo-and-contentEquals

pankratz76 changed the title ~~WIP: Fix PMD rule LiteralsFirstInComparisons for compareTo* and contentEquals~~ Fix PMD rule LiteralsFirstInComparisons for compareTo* and contentEquals Feb 7, 2025

pankratz76 changed the title ~~Fix PMD rule LiteralsFirstInComparisons for compareTo* and contentEquals~~ Fix PMD rule LiteralsFirstInComparisons for compareTo* and contentEquals Feb 7, 2025

pankratz76 changed the title ~~Fix PMD rule LiteralsFirstInComparisons for compareTo* and contentEquals~~ Fix PMD rule LiteralsFirstInComparisons for compareTo* and contentEquals Feb 7, 2025

timtebeek reviewed Feb 7, 2025

View reviewed changes

github-actions bot reviewed Feb 7, 2025

View reviewed changes

src/main/java/org/openrewrite/staticanalysis/EqualsAvoidsNull.java Outdated Show resolved Hide resolved

pankratz76 force-pushed the Fix-PMD-rule-LiteralsFirstInComparisons-for-compareTo-and-contentEquals branch from e493fd6 to decf84b Compare February 7, 2025 10:10

timtebeek marked this pull request as draft February 7, 2025 11:44

Vincent Potucek added 2 commits February 9, 2025 13:14

duplicate retainCompareToAsToNotChangeOrder

8512dbf

Merge branch 'main' into Fix-PMD-rule-LiteralsFirstInComparisons-for-…

df5a264

…compareTo-and-contentEquals # Conflicts: # src/main/java/org/openrewrite/staticanalysis/EqualsAvoidsNullVisitor.java

github-actions bot reviewed Feb 9, 2025

View reviewed changes

pankratz76 mentioned this pull request Feb 9, 2025

Invert conditional keep order on object for compare #459

Closed

Vincent Potucek added 2 commits February 9, 2025 14:20

undo

7d9975f

resolve comparison

0ae11da

pankratz76 force-pushed the Fix-PMD-rule-LiteralsFirstInComparisons-for-compareTo-and-contentEquals branch from aa6fce0 to 0ae11da Compare February 9, 2025 13:42

github-actions bot reviewed Feb 9, 2025

View reviewed changes

Vincent Potucek added 4 commits February 9, 2025 15:16

inline

905573f

inline

ac52710

inline

f6016dd

inline

8b8bd10

pankratz76 marked this pull request as ready for review February 9, 2025 14:24

pankratz76 requested a review from timtebeek February 9, 2025 14:24

github-actions bot reviewed Feb 9, 2025

View reviewed changes

Vincent Potucek added 2 commits February 9, 2025 16:13

form

74cd190

Revert "form"

46f143b

This reverts commit 74cd190.

pankratz76 force-pushed the Fix-PMD-rule-LiteralsFirstInComparisons-for-compareTo-and-contentEquals branch from cdf95f7 to 46f143b Compare February 9, 2025 15:15

github-actions bot reviewed Feb 9, 2025

View reviewed changes

pankratz76 force-pushed the Fix-PMD-rule-LiteralsFirstInComparisons-for-compareTo-and-contentEquals branch from a65c948 to 46f143b Compare February 9, 2025 19:50

github-actions bot reviewed Feb 9, 2025

View reviewed changes

remove duplicated tests, wrapping visitor and clean-ups

5818a6e

github-actions bot reviewed Feb 10, 2025

View reviewed changes

fix style and import

c20e777

github-actions bot reviewed Feb 10, 2025

View reviewed changes

src/main/java/org/openrewrite/staticanalysis/EqualsAvoidsNull.java Outdated Show resolved Hide resolved

MBoegers and others added 2 commits February 10, 2025 16:10

Update src/main/java/org/openrewrite/staticanalysis/EqualsAvoidsNull.…

fe68ae1

…java Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

reintroduced variable after GitHUb removed it..

ce96ade

github-actions bot reviewed Feb 10, 2025

View reviewed changes

MBoegers approved these changes Feb 10, 2025

View reviewed changes

MBoegers merged commit e166e5a into openrewrite:main Feb 11, 2025
2 checks passed

MBoegers self-assigned this Feb 11, 2025

pankratz76 mentioned this pull request Feb 11, 2025

Fix PMD rule LiteralsFirstInComparisons for compareTo* and contentEquals #362

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix PMD rule `LiteralsFirstInComparisons` for `compareTo*` and `contentEquals` #448

Fix PMD rule `LiteralsFirstInComparisons` for `compareTo*` and `contentEquals` #448

pankratz76 commented Jan 23, 2025 •

edited by timtebeek

Loading

pankratz76 commented Jan 23, 2025

pankratz76 left a comment

timtebeek Feb 7, 2025

MBoegers Feb 7, 2025

MBoegers Feb 10, 2025 •

edited

Loading

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

pankratz76 commented Feb 9, 2025

github-actions bot left a comment

github-actions bot left a comment

timtebeek commented Feb 9, 2025

pankratz76 commented Feb 9, 2025

pankratz76 commented Feb 9, 2025 •

edited

Loading

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

MBoegers left a comment

Fix PMD rule LiteralsFirstInComparisons for compareTo* and contentEquals #448

Fix PMD rule LiteralsFirstInComparisons for compareTo* and contentEquals #448

Conversation

pankratz76 commented Jan 23, 2025 • edited by timtebeek Loading

pankratz76 commented Jan 23, 2025

pankratz76 left a comment

Choose a reason for hiding this comment

timtebeek Feb 7, 2025

Choose a reason for hiding this comment

MBoegers Feb 7, 2025

Choose a reason for hiding this comment

MBoegers Feb 10, 2025 • edited Loading

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

pankratz76 commented Feb 9, 2025

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

timtebeek commented Feb 9, 2025

pankratz76 commented Feb 9, 2025

pankratz76 commented Feb 9, 2025 • edited Loading

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

MBoegers left a comment

Choose a reason for hiding this comment

Fix PMD rule `LiteralsFirstInComparisons` for `compareTo*` and `contentEquals` #448

Fix PMD rule `LiteralsFirstInComparisons` for `compareTo*` and `contentEquals` #448

pankratz76 commented Jan 23, 2025 •

edited by timtebeek

Loading

MBoegers Feb 10, 2025 •

edited

Loading

pankratz76 commented Feb 9, 2025 •

edited

Loading