Validate urlPath before execute, prevent null pointer exception #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Samnang-An thank you so much for this contribution! Do you mind creating a JIRA ticket as required by this? https://wiki.openmrs.org/display/docs/Pull+Request+Tips |
|
Thanks @dkayiwa for your response.Sorry for skipping the required step; however, I was trying to create an issue in Jira but I have problem login in to the Jira. can you help me with that? |
|
@Samnang-An can you report this to OpenMRS help desk? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear whom it may concern,
I would like to suggest an improvement regarding the operation of Login page which currently produces an issue when the redirect URL context path is blank. Please refer to the screenshot and code change below.
Server Info:
open MRS 2.3.2 Build 437b7f
Step to reproduce:
The error shows up on the second time I redirect to login page.
Thank you very much for considering the improvement.
Best Regards,
Samnang