modified: api/src/main/resources/moduleApplicationContext.xml #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modified: omod/gulpfile.js modified: pom.xml
|
Some of the errors that appear when the module is run on a new core model have been resolved, but still a long way to go. |
dkayiwa
reviewed
Mar 7, 2024
| var gulp = require('gulp'); | ||
| var mainBowerFiles = require('main-bower-files'); | ||
| var uglify = require('gulp-uglify'); | ||
| var cleanCSS = require('gulp-clean-css') |
There was a problem hiding this comment.
How are the changes in this file related to making the module run on the latest core platform?
|
Each time I could try to add the module, it kept giving me Spring errors
because of version incompatibility. So I started changing the invalid
syntax in the moduleContex file and in the pom.xml and then changed the
outdated dependencies in the gulf file since an old version of Node was
used.
…On Thu, Mar 7, 2024 at 1:26 PM dkayiwa ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In omod/gulpfile.js
<#522 (comment)>
:
> @@ -1,83 +1,212 @@
-var gulp = require('gulp');
-var mainBowerFiles = require('main-bower-files');
-var uglify = require('gulp-uglify');
-var cleanCSS = require('gulp-clean-css')
How are the changes in this file related to making the module run on the
latest core platform?
—
Reply to this email directly, view it on GitHub
<#522 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AYTE3CO3SEL37BI34N7ZBJLYXBFGZAVCNFSM6AAAAABEJ7UT6WVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSMRSGE4DOMBXHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
To be honest, I am not really sure about where I am supposed to start the
updating from.
On Thu, Mar 7, 2024 at 2:04 PM Lishebo Lishebo ***@***.***>
wrote:
… Each time I could try to add the module, it kept giving me Spring errors
because of version incompatibility. So I started changing the invalid
syntax in the moduleContex file and in the pom.xml and then changed the
outdated dependencies in the gulf file since an old version of Node was
used.
On Thu, Mar 7, 2024 at 1:26 PM dkayiwa ***@***.***> wrote:
> ***@***.**** commented on this pull request.
> ------------------------------
>
> In omod/gulpfile.js
> <#522 (comment)>
> :
>
> > @@ -1,83 +1,212 @@
> -var gulp = require('gulp');
> -var mainBowerFiles = require('main-bower-files');
> -var uglify = require('gulp-uglify');
> -var cleanCSS = require('gulp-clean-css')
>
> How are the changes in this file related to making the module run on the
> latest core platform?
>
> —
> Reply to this email directly, view it on GitHub
> <#522 (review)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AYTE3CO3SEL37BI34N7ZBJLYXBFGZAVCNFSM6AAAAABEJ7UT6WVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSMRSGE4DOMBXHE>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
|
|
Spring and Node do not look related. I would separate the two. |
It would be easier for you to do a separate pull request for each category of errors. For instance the changes you made in moduleApplicationContext.xml are correct and deal with a certain category of errors, hence a good candidate for their own pull request. |
|
Thanks, I was getting the node errors on compilation.
Do you think resolving errors one by one will yield something or am I on a
wild goose chase here?
…On Thu, Mar 7, 2024 at 2:10 PM dkayiwa ***@***.***> wrote:
To be honest, I am not really sure about where I am supposed to start the
updating from.
It would be easier for you to do a separate pull request for each category
of errors. For instance the changes you made in
moduleApplicationContext.xml are correct and deal with a certain category
of errors, hence a good candidate for their own pull request.
—
Reply to this email directly, view it on GitHub
<#522 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AYTE3CMNLIGWQZXCRT36NIDYXBKJ5AVCNFSM6AAAAABEJ7UT6WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBTGM3TQMBVHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Addressing those errors one by one will be the easiest way for you to make progress. |
|
Alright, Thanks
…On Thu, Mar 7, 2024 at 2:35 PM dkayiwa ***@***.***> wrote:
Addressing those errors one by one will be the easiest way for you to make
progress.
—
Reply to this email directly, view it on GitHub
<#522 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AYTE3CKPD6WWZSVAXVHSDODYXBNIBAVCNFSM6AAAAABEJ7UT6WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBTGQYTQMBVG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
see https://issues.openmrs.org/browse/RAD-
Checklist:
git pull --rebase upstream master.mvn clean packageright before creating this pull request andadded all formatting changes to my commit.