Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PROV-103: Fixes of Provider Management UI crashes when we select provider from search result on openmrs platform 2.x.x #48

Closed
wants to merge 3 commits into from

Conversation

josephbate
Copy link
Contributor

Description of what I changed

  1. Added a try catch method to load the NameSupport class from either rg.openmrs.layout.name or org.openmrs.layout.web.name depending on which one is required
  2. Used reflection to invoke the "getInstance" method and also getDefaultLayoutTemplate" method to creat objects
  3. later invoked the instance object to get the layoutTemplate

Issue I worked on

see https://issues.openmrs.org/browse/PROV-103?focusedCommentId=291664#comment-291664

Checklist: I completed these to help reviewers :)

  • My IDE is configured to follow the code style of this project.

    No? Unsure? -> configure your IDE, format the code and add the changes with git add . && git commit --amend

  • I have added tests to cover my changes. (If you refactored
    existing code that was well tested you do not have to add tests)

    No? -> write tests and add them to this commit git add . && git commit --amend

  • I ran mvn clean package right before creating this pull request and
    added all formatting changes to my commit.

    No? -> execute above command

  • All new and existing tests passed.

    No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.

  • My pull request is based on the latest changes of the master branch.

    No? Unsure? -> execute command git pull --rebase upstream master

@josephbate
Copy link
Contributor Author

josephbate commented Nov 15, 2023

hello @dkayiwa does this work fine ?

@dkayiwa
Copy link
Member

dkayiwa commented Nov 15, 2023

Commit messages should include the ticket id https://wiki.openmrs.org/display/docs/Pull+Request+Tips

import org.openmrs.ui.framework.fragment.FragmentModel;

/**
* This class retrieves the layout template using reflection.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not find this comment helpful. Can we remove it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

@dkayiwa
Copy link
Member

dkayiwa commented Nov 15, 2023

@josephbate Commit messages should include the ticket id https://wiki.openmrs.org/display/docs/Pull+Request+Tips

This reverts commit fdd74d8.
@josephbate josephbate closed this by deleting the head repository Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants