-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prov 103:Provider Management UI crashes when we select provider from search result on openmrs platform 2.x.x #47
Conversation
…via reflection for openmrs version 2.x.x solve a backward incompatibility change
PROV-103: Provider Management UI crashes when we select provider from search result on openmrs platform 2.x.x fix
Can you remove the version changes that i see here? https://github.com/openmrs/openmrs-module-providermanagement/pull/47/files |
hello @dkayiwa could you help on this because there is no maintainace branch for this module i cannot see how to go about it |
You do not need a maintenance branch. You can just create a new local branch from master, put in the changes, and then raise a new pull request. |
Description of what I changed
Issue I worked on
see https://issues.openmrs.org/browse/PROV-103?focusedCommentId=291664#comment-291664
Checklist: I completed these to help reviewers :)
My IDE is configured to follow the code style of this project.
No? Unsure? -> configure your IDE, format the code and add the changes with
git add . && git commit --amend
I have added tests to cover my changes. (If you refactored
existing code that was well tested you do not have to add tests)
No? -> write tests and add them to this commit
git add . && git commit --amend
I ran
mvn clean package
right before creating this pull request andadded all formatting changes to my commit.
No? -> execute above command
All new and existing tests passed.
No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.
My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command
git pull --rebase upstream master