Prov 103 [issue](https://issues.openmrs.org/browse/PROV-103) #45
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -14,13 +14,46 @@ | |||||
|
|
||||||
| package org.openmrs.module.providermanagement.fragment.controller; | ||||||
|
|
||||||
| import java.lang.reflect.Method; | ||||||
| import java.lang.reflect.InvocationTargetException; | ||||||
|
|
||||||
| import org.openmrs.ui.framework.fragment.FragmentModel; | ||||||
|
|
||||||
| public class PersonNameFragmentController { | ||||||
|
|
||||||
| /** | ||||||
| * @param model | ||||||
| * @throws ClassNotFoundException | ||||||
| * @throws SecurityException | ||||||
| * @throws NoSuchMethodException | ||||||
| * @throws InvocationTargetException | ||||||
| * @throws IllegalArgumentException | ||||||
| * @throws IllegalAccessException | ||||||
| */ | ||||||
|
|
||||||
| public void controller(FragmentModel model) throws ClassNotFoundException, NoSuchMethodException, SecurityException, | ||||||
|
There was a problem hiding this comment. I think at this point, its just easier to say There was a problem hiding this comment. Also, is there nothing we can do here to recover from these exceptions? There was a problem hiding this comment. do you have any suggestions @ibacher |
||||||
| IllegalAccessException, IllegalArgumentException, InvocationTargetException { | ||||||
|
|
||||||
| /* | ||||||
| * backward compatibility | ||||||
| */ | ||||||
| Class<?> nameSurpport; | ||||||
|
There was a problem hiding this comment.
Suggested change
There was a problem hiding this comment. hello @ibacher thank you for pointing them out let me try to solve them |
||||||
|
|
||||||
| try { | ||||||
| nameSurpport = Class.forName("org.openmrs.layout.name.NameSupport"); | ||||||
| } | ||||||
| catch (ClassNotFoundException e) { | ||||||
| nameSurpport = Class.forName("org.openmrs.layout.web.name.NameSupport"); | ||||||
| } | ||||||
|
|
||||||
| Method getInstance = nameSurpport.getDeclaredMethod("getInstance"); | ||||||
| Object instance = getInstance.invoke(null); | ||||||
|
|
||||||
| Method getLayoutTemplate = nameSurpport.getMethod("getDefaultLayoutTemplate"); | ||||||
| Object layoutTemplate = getLayoutTemplate.invoke(instance); | ||||||
|
|
||||||
| model.addAttribute("layoutTemplate", layoutTemplate); | ||||||
|
|
||||||
| } | ||||||
|
|
||||||
| } | ||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're going to include Javadocs, they should actually provide some information.