-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HIE-2] Skeleton code for client registry search flow #5
Closed
Closed
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
e14b7ae
[HIE-2] client registry Patient search flow implementation
pmanko2 168811a
[HIE-2] differentiate between source system and target systems
pmanko2 bfe4f37
rename interface method and start on correct parsing of operation res…
pmanko2 87f0b85
use onType
pmanko2 9afdeba
[HIE-2] make CR request for patients matching identifiers returned by…
pmanko2 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 6 additions & 0 deletions
6
api/src/main/java/org/openmrs/module/clientregistry/ClientRegistryTransactionType.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
package org.openmrs.module.clientregistry; | ||
|
||
public enum ClientRegistryTransactionType { | ||
FHIR, | ||
HL7 | ||
} |
13 changes: 13 additions & 0 deletions
13
api/src/main/java/org/openmrs/module/clientregistry/api/CRPatientService.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
package org.openmrs.module.clientregistry.api; | ||
|
||
import org.hl7.fhir.r4.model.Patient; | ||
import org.openmrs.module.fhir2.api.search.param.PatientSearchParams; | ||
|
||
import java.util.List; | ||
|
||
public interface CRPatientService { | ||
|
||
List<Patient> getCRPatients(String sourceIdentifier, String sourceIdentifierSystem, List<String> extraTargetSystems); | ||
|
||
List<Patient> searchCRForPatients(PatientSearchParams patientSearchParams); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
77 changes: 77 additions & 0 deletions
77
api/src/main/java/org/openmrs/module/clientregistry/api/impl/FhirCRPatientServiceImpl.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,77 @@ | ||
package org.openmrs.module.clientregistry.api.impl; | ||
|
||
import ca.uhn.fhir.rest.client.api.IGenericClient; | ||
import ca.uhn.fhir.rest.gclient.IQuery; | ||
import org.hl7.fhir.instance.model.api.IBaseBundle; | ||
import org.hl7.fhir.r4.model.Bundle; | ||
import org.hl7.fhir.r4.model.Parameters; | ||
import org.hl7.fhir.r4.model.Patient; | ||
import org.openmrs.module.clientregistry.ClientRegistryConfig; | ||
import org.openmrs.module.clientregistry.api.CRPatientService; | ||
import org.openmrs.module.clientregistry.providers.FhirCRConstants; | ||
import org.openmrs.module.fhir2.FhirConstants; | ||
import org.openmrs.module.fhir2.api.search.param.PatientSearchParams; | ||
import org.springframework.beans.factory.annotation.Autowired; | ||
import org.springframework.stereotype.Component; | ||
|
||
import java.util.List; | ||
import java.util.stream.Collectors; | ||
|
||
@Component | ||
public class FhirCRPatientServiceImpl implements CRPatientService { | ||
|
||
@Autowired | ||
private IGenericClient fhirClient; | ||
|
||
@Autowired | ||
private ClientRegistryConfig config; | ||
|
||
/** | ||
* Constructs a $ihe-pix fhir client call to an external Client Registry returning any patients | ||
* that match the given source identifier/system and target systems. | ||
*/ | ||
@Override | ||
public List<Patient> getCRPatients(String sourceIdentifier, String sourceIdentifierSystem, List<String> targetSystems) { | ||
|
||
|
||
Parameters betterCrRequest = fhirClient | ||
.operation() | ||
.onInstance(String.format("%s|%s", sourceIdentifierSystem, sourceIdentifier)) | ||
.named(FhirCRConstants.IHE_PIX_OPERATION) | ||
.withNoParameters(Parameters.class) | ||
.execute(); | ||
samuelmale marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
// construct and send request to external client registry | ||
IQuery<IBaseBundle> crRequest = fhirClient | ||
.search() | ||
.byUrl( | ||
String.format("%s/%s", config.getClientRegistryServerUrl(), config.getClientRegistryGetPatientEndpoint())) | ||
.where( | ||
FhirCRConstants.SOURCE_IDENTIFIER_PARAM.exactly().systemAndIdentifier(sourceIdentifierSystem, | ||
sourceIdentifier)); | ||
|
||
if (!targetSystems.isEmpty()) { | ||
crRequest.and(FhirCRConstants.TARGET_SYSTEM_PARAM.matches().values(targetSystems)); | ||
} | ||
|
||
Bundle patientBundle = crRequest.returnBundle(Bundle.class).execute(); | ||
return parseCRPatientSearchResults(patientBundle); | ||
} | ||
|
||
@Override | ||
public List<Patient> searchCRForPatients(PatientSearchParams patientSearchParams) { | ||
return null; | ||
} | ||
|
||
/** | ||
* Filter and parse out fhir patients from Client Registry Patient Search results | ||
*/ | ||
private List<Patient> parseCRPatientSearchResults(Bundle patientBundle) { | ||
return patientBundle | ||
.getEntry() | ||
.stream() | ||
.filter(entry -> entry.hasType(FhirConstants.PATIENT)) | ||
.map(entry -> (Patient) entry.getResource()) | ||
.collect(Collectors.toList()); | ||
} | ||
} |
26 changes: 26 additions & 0 deletions
26
api/src/main/java/org/openmrs/module/clientregistry/providers/FhirCRConstants.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
package org.openmrs.module.clientregistry.providers; | ||
|
||
import ca.uhn.fhir.model.api.annotation.SearchParamDefinition; | ||
import ca.uhn.fhir.rest.gclient.StringClientParam; | ||
import ca.uhn.fhir.rest.gclient.TokenClientParam; | ||
import ca.uhn.fhir.rest.gclient.UriClientParam; | ||
|
||
public class FhirCRConstants { | ||
|
||
public static final String IHE_PIX_OPERATION = "$ihe-pix"; | ||
|
||
@SearchParamDefinition(name = "sourceIdentifier", path = "Patient.sourceIdentifier", description = "A patient identifier used to find cross-matching identifiers in client registry", type = "token") | ||
public static final String SOURCE_IDENTIFIER = "sourceIdentifier"; | ||
|
||
public static final TokenClientParam SOURCE_IDENTIFIER_PARAM = new TokenClientParam("sourceIdentifier"); | ||
|
||
@SearchParamDefinition(name = "targetSystem", path = "Patient.targetSystem", description = "Assigning Authorities for the Patient Identifier Domains from which the returned identifiers shall be selected", type = "token") | ||
public static final String TARGET_SYSTEM = "targetSystem"; | ||
|
||
public static final UriClientParam TARGET_SYSTEM_PARAM = new UriClientParam("targetSystem"); | ||
|
||
@SearchParamDefinition(name = "_format", path = "Patient.targetSystem", description = "Assigning Authorities for the Patient Identifier Domains from which the returned identifiers shall be selected", type = "token") | ||
public static final String _FORMAT = "_FORMAT"; | ||
|
||
public static final StringClientParam _FORMAT_PARAM = new StringClientParam("_format"); | ||
} |
99 changes: 99 additions & 0 deletions
99
...in/java/org/openmrs/module/clientregistry/providers/r4/FhirCRPatientResourceProvider.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,99 @@ | ||
package org.openmrs.module.clientregistry.providers.r4; | ||
|
||
import ca.uhn.fhir.model.valueset.BundleTypeEnum; | ||
import ca.uhn.fhir.rest.annotation.Search; | ||
import ca.uhn.fhir.rest.param.StringParam; | ||
import ca.uhn.fhir.rest.param.StringOrListParam; | ||
import ca.uhn.fhir.rest.param.TokenParam; | ||
import ca.uhn.fhir.rest.server.IResourceProvider; | ||
import ca.uhn.fhir.rest.server.exceptions.InvalidRequestException; | ||
import ca.uhn.fhir.rest.server.exceptions.NotImplementedOperationException; | ||
import ca.uhn.fhir.rest.server.exceptions.ResourceNotFoundException; | ||
import lombok.Setter; | ||
import org.hl7.fhir.instance.model.api.IBaseResource; | ||
import org.hl7.fhir.r4.model.Patient; | ||
import ca.uhn.fhir.rest.annotation.Operation; | ||
import ca.uhn.fhir.rest.annotation.OperationParam; | ||
import org.openmrs.module.clientregistry.ClientRegistryConfig; | ||
import org.openmrs.module.clientregistry.api.ClientRegistryManager; | ||
import org.openmrs.module.clientregistry.providers.FhirCRConstants; | ||
import org.openmrs.module.fhir2.api.annotations.R4Provider; | ||
import org.springframework.beans.factory.annotation.Autowired; | ||
import org.springframework.stereotype.Component; | ||
|
||
import java.util.Collections; | ||
import java.util.List; | ||
import java.util.Objects; | ||
import java.util.stream.Collectors; | ||
|
||
import static lombok.AccessLevel.PACKAGE; | ||
|
||
@Component("crPatientFhirR4ResourceProvider") | ||
@R4Provider | ||
@Setter(PACKAGE) | ||
public class FhirCRPatientResourceProvider implements IResourceProvider { | ||
|
||
@Autowired | ||
private ClientRegistryManager clientRegistryManager; | ||
|
||
@Autowired | ||
private ClientRegistryConfig config; | ||
|
||
@Override | ||
public Class<? extends IBaseResource> getResourceType() { | ||
return Patient.class; | ||
} | ||
|
||
/** | ||
* FHIR endpoint to get Patient references from external client registry Example request: GET | ||
* [fhirbase | ||
* ]/Patient/$ihe-pix?sourceIdentifier={sourceSystem|}1234[&targetSystem=system1,system2] | ||
* | ||
* @param sourceIdentifierParam patient identifier token. If source system is included in token, | ||
* we will use it to override the module defined source system. | ||
* @param targetSystemsParam (optional) Patient assigning authorities (ie systems) from which | ||
* the returned identifiers shall be selected | ||
* @return List of matching FHIR patients returned by the client registry | ||
*/ | ||
@Operation(name = FhirCRConstants.IHE_PIX_OPERATION, idempotent=true, type = Patient.class, bundleType = BundleTypeEnum.SEARCHSET) | ||
public List<Patient> getCRPatientById( | ||
@OperationParam(name = FhirCRConstants.SOURCE_IDENTIFIER) TokenParam sourceIdentifierParam, | ||
@OperationParam(name = FhirCRConstants.TARGET_SYSTEM) StringOrListParam targetSystemsParam | ||
) { | ||
|
||
if (sourceIdentifierParam == null || sourceIdentifierParam.getValue() == null) { | ||
throw new InvalidRequestException("sourceIdentifier must be specified"); | ||
} | ||
|
||
List<String> targetSystems = targetSystemsParam == null | ||
? Collections.emptyList() | ||
: targetSystemsParam.getValuesAsQueryTokens().stream().filter(Objects::nonNull).map(StringParam::getValue).collect(Collectors.toList()); | ||
|
||
// If no sourceSystem provided, use config defined default | ||
boolean userDefinedSourceSystem = sourceIdentifierParam.getSystem() != null && !sourceIdentifierParam.getSystem().isEmpty(); | ||
String sourceIdentifierSystem = userDefinedSourceSystem | ||
? sourceIdentifierParam.getSystem() | ||
: config.getClientRegistryDefaultPatientIdentifierSystem(); | ||
|
||
if (sourceIdentifierSystem == null || sourceIdentifierSystem.isEmpty()) { | ||
throw new InvalidRequestException("ClientRegistry module does not have a default source system assigned " + | ||
"via the defaultPatientIdentifierSystem property. Source system must be provided as a token in " + | ||
"the sourceIdentifier request param"); | ||
} | ||
|
||
List<Patient> patients = clientRegistryManager.getPatientService().getCRPatients( | ||
sourceIdentifierParam.getValue(), sourceIdentifierSystem, targetSystems | ||
); | ||
|
||
if (patients.isEmpty()) { | ||
throw new ResourceNotFoundException("No Client Registry patients found."); | ||
} | ||
|
||
return patients; | ||
} | ||
|
||
@Search | ||
public List<Patient> searchClientRegistryPatients() { | ||
throw new NotImplementedOperationException("search client registry is not yet implemented"); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -35,13 +35,37 @@ | |
|
||
<!-- Required Global Properties --> | ||
<globalProperty> | ||
<property>@MODULE_ID@.serverUrl</property> | ||
<defaultValue>http://localhost:5001/CR/fhir/</defaultValue> | ||
<property>@MODULE_ID@.clientRegistryServerUrl</property> | ||
<defaultValue>http://localhost:5001/CR/fhir</defaultValue> | ||
<description> | ||
Base URL for the Client Registry Server | ||
</description> | ||
</globalProperty> | ||
|
||
<globalProperty> | ||
<property>@[email protected]</property> | ||
<defaultValue>Patient/$ihe-pix</defaultValue> | ||
<description> | ||
Client registry endpoint implementing the Patient identifier cross-reference transaction (ITI-83) | ||
</description> | ||
</globalProperty> | ||
|
||
<globalProperty> | ||
<property>@[email protected]</property> | ||
<defaultValue></defaultValue> | ||
<description> | ||
Default system from which the Patient identifiers will be returned, if no system provided in requests | ||
</description> | ||
</globalProperty> | ||
|
||
<globalProperty> | ||
<property>@[email protected]</property> | ||
<defaultValue>fhir</defaultValue> | ||
<description> | ||
Transaction method supported by the Client Registry. Currently supporting fhir or hl7. | ||
</description> | ||
</globalProperty> | ||
|
||
<globalProperty> | ||
<property>@[email protected]</property> | ||
<defaultValue>openmrs</defaultValue> | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this only needs to be determined once on module startup (and on property changed/deleted), maybe we move the logic into
ClientRegistryActivator
?