-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(test) O3-2943: E2E test for Immunizations workflow #2148
base: main
Are you sure you want to change the base?
(test) O3-2943: E2E test for Immunizations workflow #2148
Conversation
@Muta-Jonathan could you fix the failing build at https://github.com/openmrs/openmrs-esm-patient-chart/actions/runs/12283806300/job/34334997423?pr=2148? |
cc @kdaud |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Muta-Jonathan. The PR looks good overall. I left one comment to address.
- Can you add the ticket URL and also update the PR title?
@kdaud also this seems resolved by @NethmiRodrigo |
@Muta-Jonathan could you take a look at the PR title? |
cc @kdaud |
@Muta-Jonathan checkout → #2148 (comment) |
@Muta-Jonathan what is going on with the tests? →https://github.com/openmrs/openmrs-esm-patient-chart/actions/runs/13154975168/job/36711454286?pr=2148 |
@kdaud this is caused due to a switch to use of content packages its being looked into by @dkayiwa @jayasanka-sack and @NethmiRodrigo |
cc @kdaud now are running successfully big thanks to @NethmiRodrigo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@denniskigen could you review this PR when you find time? BTW I can't request reviews via the GA UI.
Requirements
Summary
This PR introduces changes that edits E2E test for a recorded immunization
Screenrecord
Screen.Recording.2024-12-17.at.12.14.19.PM.mov
Related Issue
https://openmrs.atlassian.net/jira/software/c/projects/O3/issues/O3-2943