(fix) O3-4159: Workspace should not cover content on service queues page #234
Conversation
|
Hello, @brandones, kindly feel free to review my PR at your convenient time please. |
denniskigen
changed the title
| @@ -23,7 +23,7 @@ export default function HomeDashboard() { | |||
| {isDesktop(layout) && <ExtensionSlot name="home-sidebar-slot" key={layout} />} | |||
| <DashboardView title={activeDashboard?.name} dashboardSlot={activeDashboard?.slot} /> | |||
| </section> | |||
| <WorkspaceContainer overlay contextKey="home" /> | |||
| <WorkspaceContainer contextKey="home" /> | |||
There was a problem hiding this comment.
This change will be made for all the workspaces shown on the /home path, which also includes Wards Workspaces and others.
There was a problem hiding this comment.
@vasharma05, You are right, and I raised the same question during the coffee break (10 Dec 2024) while we were debugging the issue. My suggestion then was to avoid affecting other workspaces by ensuring that each workspace has its own WorkspaceContainer component, with an overlay on top of the content to simplify styling without affecting other workspaces. The main essence of pushing this PR was to get members' views after implementing what @brandones had suggested on the ticket.
Requirements
Summary
Previously, the home workspace container rendered as an overlay that covered existing content. Now it renders as a standard workspace that pushes content on the page to the left, matching the behavior in other parts of the application. The key changes this PR makes is removing the
overlayprop from the workspace container, which effectively turns it into a standard workspace.Screenshots
Related issue
https://openmrs.atlassian.net/browse/O3-4159
Other