-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feat) O3-1494: Add report admin dashboard #45
Conversation
I expect that Palladium-Kenya will be interested in using this so I reached out to @ojwanganto: @jecihjoy he recommended you review this PR :) |
Changed to DRAFT, because it's not adapted to changes in API in openmrs/openmrs-module-reportingrest#33 |
So TBH I didn't notice until now that this PR is almost 12k lines of code - woah. Reviewing this make take our support & community members quite some time. In future smaller PRs earlier would be more advisable :) Hope that makes sense! |
@gracepotma - Should we have this work as part of the admin tools or a separate reporting-esm? |
@ojwanganto Well, it is a separate esm, just in this mono-repo. I don't think we need individual GitHub repos for everything. |
Makes sense @ibacher. I think i didn't get into the source code. I just looked at the project URL. Sorry about that |
@pwargulak when do you think we can start testing this work? It already provides a good foundation for the reporting functionality we need |
@ojwanganto We are working on bringing the BE code to sufficient quality, the PRs related to BE are listed here once they are merged we'll adapt the FE (this PR) and then it can be tested. |
Thanks for the update @pwargulak. |
Iam curios to know if anyone has used this.. may need it somewhere @pwargulak @jecihjoy |
- Reports overview - Report schedules overview
5d966d4
to
d4eaa1b
Compare
@denniskigen @ibacher as two required backend PRs have been merged I adapted this PR to mentioned backend changes and open PR once again for review. Can you take a look? Piotr's first comment gives a quick overview what has been done here |
@ibacher @denniskigen @jecihjoy I kindly remind you about this PR. Can you take a look? |
Looping in @makombe @donaldkibet |
@denniskigen @ibacher @brandones @jecihjoy @makombe @donaldkibet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for getting this off the ground, @pwargulak! I've left some suggestions.
...sm-reports-app/src/components/edit-scheduled-report/edit-scheduled-report-form.component.tsx
Show resolved
Hide resolved
...sm-reports-app/src/components/edit-scheduled-report/edit-scheduled-report-form.component.tsx
Outdated
Show resolved
Hide resolved
...sm-reports-app/src/components/edit-scheduled-report/edit-scheduled-report-form.component.tsx
Outdated
Show resolved
Hide resolved
...sm-reports-app/src/components/edit-scheduled-report/edit-scheduled-report-form.component.tsx
Show resolved
Hide resolved
packages/esm-reports-app/src/components/run-report/run-report-form.component.tsx
Outdated
Show resolved
Hide resolved
packages/esm-reports-app/src/components/run-report/run-report-form.component.tsx
Outdated
Show resolved
Hide resolved
packages/esm-reports-app/src/components/scheduled-report-status.component.tsx
Outdated
Show resolved
Hide resolved
9347544
to
167e63e
Compare
@denniskigen I addressed your comments and also make similar corrections in other places in app, not only with those indicated by you. Can you take a look? |
Hey @denniskigen , will you be able to look on my latest changes? (made according to your last comments) |
packages/esm-reports-app/src/components/run-report/run-report-form.scss
Outdated
Show resolved
Hide resolved
packages/esm-reports-app/src/components/run-report/cancel-report-modal.component.tsx
Outdated
Show resolved
Hide resolved
packages/esm-reports-app/src/components/run-report/cancel-report-modal.component.tsx
Show resolved
Hide resolved
packages/esm-reports-app/src/components/run-report/cancel-report-modal.component.tsx
Outdated
Show resolved
Hide resolved
packages/esm-reports-app/src/components/run-report/cancel-report-modal.component.tsx
Outdated
Show resolved
Hide resolved
Hi @denniskigen , next changes have been pushed. Can you take a look? |
Great work getting this over the line, @druchniewicz @pwargulak! Here's some additional changes to consider as potential future iterations:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the great work! Merging shortly; the e2e test failure seems unrelated to your changes.
Thanks @denniskigen for reliable code review and suggestions how your comments should be addressed! |
Another important next step I forgot to mention: adding the reports app to the reference application's spa-assemble-config.json file so it gets included in the importmap. |
Summary
The PR contains implementation of Report administration pages, including:
Pages are accessible via System Administration menu.
It implements designs documented here (newest mocks section).
Screenshots
Issue
https://openmrs.atlassian.net/browse/O3-1494