Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

O3-4396: Synced E2E tests with RefApp config #881

Closed
wants to merge 2 commits into from

Conversation

Lemeri123
Copy link

No description provided.

@Lemeri123
Copy link
Author

@ibacher please review this and let me know if I need to make any changes

@jayasanka-sack
Copy link
Member

Hey @Lemeri123, could you provide a bit of context of what this PR is all about and what it’s trying to fix?

@Lemeri123
Copy link
Author

Well first-off, it solves this issue "https://openmrs.atlassian.net/browse/O3-4396" and it was about modifying the E2E tests to have the same configuration as the configuration used in the config-core_demo.json.

Copy link
Member

@ibacher ibacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you test this out? I don't see how this actually gets the configuration file where it needs to be to be available during the E2E tests.

AFAICT, fixing this issue should be just modifying the SPA_CONFIG_URLS variable here.

@Lemeri123
Copy link
Author

image
Ohhh I thought it was about syncing the E2E test with the RefApp. so as for that, I was successful😅let me see what I can do thou

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants