Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved PHP docker to the PHP repository #143

Merged
merged 2 commits into from
Oct 10, 2024
Merged

Conversation

josvandervelde
Copy link
Member

@josvandervelde josvandervelde commented Jan 11, 2024

See openml/OpenML#1212.

For the https://github.com/openml/services/tree/feature/docker-compose, I've chosen to use elasticsearch 6.8.23 (same as production) for now.

I've updated openml/php-rest-api docker container to work with ES6. This is problematic for this server-api repo. A simple solution could be to create openml/php-rest-api:es8. What do you think?

@PGijsbers
Copy link
Contributor

I think that's fine. Would also need to update the docker-compose.

@PGijsbers
Copy link
Contributor

I think downgrading ES should accomplish the same thing?
There is still a minor issue of some ES errors, but those exists before the downgrade too.
Only when a tag is pushed for a dataset which already had tag(s)... but it's possible this happens in production too. I'll see if it reproduces or if it's a work item for this resource.

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@19bab14). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #143   +/-   ##
=======================================
  Coverage        ?   91.93%           
=======================================
  Files           ?       49           
  Lines           ?     1823           
  Branches        ?      144           
=======================================
  Hits            ?     1676           
  Misses          ?      105           
  Partials        ?       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PGijsbers
Copy link
Contributor

Doesn't reproduce for me. Doesn't even reproduce locally for me right now, but you can see it in CI (it's the SKIPS for the tag).

@PGijsbers PGijsbers merged commit dd9682c into main Oct 10, 2024
5 checks passed
@PGijsbers PGijsbers deleted the feature/remove-php-docker branch October 10, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants