Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add/data features #117

Merged
merged 6 commits into from
Nov 30, 2023
Merged

Add/data features #117

merged 6 commits into from
Nov 30, 2023

Conversation

PGijsbers
Copy link
Contributor

Closes #9

@PGijsbers
Copy link
Contributor Author

TODO: Expand test coverage for the new endpoint

  • [ ]: all features
  • [ ]: error codes
  • [ ]: processing errors (55, 56, 59)

@PGijsbers
Copy link
Contributor Author

Left some notes in #118 in what is currently not tested (or even implemented?). But as integration tests pass against the PHP responses, I will call it done for now.

@PGijsbers PGijsbers merged commit dc46832 into main Nov 30, 2023
3 checks passed
@PGijsbers PGijsbers deleted the add/data_features_id branch November 30, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GET /data/features/{id}
1 participant
@PGijsbers