Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added handler for empty author searches. #720

Merged
merged 2 commits into from
Dec 20, 2018
Merged

Added handler for empty author searches. #720

merged 2 commits into from
Dec 20, 2018

Conversation

ajrbyers
Copy link
Member

@ajrbyers ajrbyers commented Dec 20, 2018 •
edited
Loading

This function is too long, need to move to forms/logic but a fix is in place for the empty search issue.

#721

mauromsl
mauromsl reviewed Dec 20, 2018
View reviewed changes
Copy link
Member

@mauromsl mauromsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, worth adding a check on the frontend as well?

@ajrbyers
Copy link
Member Author

@mauromsl yes, done!

@mauromsl mauromsl merged commit 52e902b into 1.3.2 Dec 20, 2018
@ajrbyers ajrbyers deleted the bugfix-empty_author_search branch December 20, 2018 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mauromsl mauromsl mauromsl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ajrbyers @mauromsl