Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Press shouldn't use contact view from journal #1720

Open
mauromsl opened this issue Jul 22, 2020 · 0 comments
Open

Press shouldn't use contact view from journal #1720

mauromsl opened this issue Jul 22, 2020 · 0 comments
Labels
new feature A new thing that doesn't exist yet

Comments

@mauromsl
Copy link
Member

Is your feature request related to a problem? Please describe.
The press contact view is using journal.views.contact.
This makes sense, since the logic is the same regardless of the site type, but it is not obvious from the view that it is being used by the press which has led to #1719

Describe the solution you'd like
Move the shared logic to core, since it will be used by all types of sites . Then we can have wrapper views on journal/press with the appropriate decorators.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature A new thing that doesn't exist yet
Projects
None yet
Development

No branches or pull requests

1 participant