Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let referring link specify which contact to select in contact form #4138

Open
joemull opened this issue Apr 29, 2024 · 2 comments
Open

Let referring link specify which contact to select in contact form #4138

joemull opened this issue Apr 29, 2024 · 2 comments
Labels
a11y Issues that relate to acessibility dev-ready This issue has been refined and is ready for development. new feature A new thing that doesn't exist yet priority-high High priority size M Medium VPAT Issue prioritised for VPAT improvements.

Comments

@joemull
Copy link
Member

joemull commented Apr 29, 2024

User journey

As an end user reading a press or journal website, if I am told to contact a particular staff person or editor, and I am linked to the /contact/ page to do so, I may be a bit confused if the pre-selected person is different than the person I was told to contact.

Proposed solution

Check for a query parameter like [email protected] and pass that argument into the form here:

https://github.com/BirkbeckCTP/janeway/blob/e48da784d523b1e4fde5c5b0ef8d8ef03f818fff/src/journal/views.py#L1886-L1896

Potential synergy

#1720

@joemull joemull added the new feature A new thing that doesn't exist yet label Apr 29, 2024
@joemull
Copy link
Member Author

joemull commented Apr 29, 2024

This will also help with openlibhums/hourglass#341.

@StephDriver StephDriver moved this to Triage in Accessibility Jun 4, 2024
@StephDriver StephDriver added a11y Issues that relate to acessibility VPAT Issue prioritised for VPAT improvements. labels Jun 27, 2024
@joemull
Copy link
Member Author

joemull commented Aug 29, 2024

Refinement discussion: To do this right, we'd want to get rid of having the email address as the part of the form or the referring link, to minimize spam. The Contact model also contains PID that isn't in an Account, so we probably want to avoid that to better meet GDPR.

So, we propose modifying the Contact model to rely on the Account model for data, and in the form and referring link, we use the account UUID or pk.

@joemull joemull added dev-ready This issue has been refined and is ready for development. size M Medium priority-high High priority labels Aug 29, 2024
@StephDriver StephDriver moved this from Triage to Sent to Dev in Accessibility Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Issues that relate to acessibility dev-ready This issue has been refined and is ready for development. new feature A new thing that doesn't exist yet priority-high High priority size M Medium VPAT Issue prioritised for VPAT improvements.
Projects
Status: Sent to Dev
Development

No branches or pull requests

2 participants