Handle unsetting of pub date #4095

openlibhums · May 30, 2024 · 2a2b7c4 · 2a2b7c4
1 parent 2e5c963
commit 2a2b7c4
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 8 deletions.
diff --git a/src/journal/views.py b/src/journal/views.py
@@ -1090,15 +1090,20 @@ def publish_article(request, article_id):
                 instance=article,
             )
             if pub_date_form.is_valid():
-                pub_date_form.save()
-                messages.add_message(
-                    request, messages.SUCCESS,
-                    _(
-                        f'Publication date set to { article.date_published.strftime("%Y-%m-%d %H:%M %Z") } '
-                        f'({ naturaltime(article.date_published) })'
+                article = pub_date_form.save()
+                if article.date_published:
+                    messages.add_message(
+                        request, messages.SUCCESS,
+                        _(
+                            f'Publication date set to { article.date_published.strftime("%Y-%m-%d %H:%M %Z") } '
+                            f'({ naturaltime(article.date_published) })'
+                        )
+                    )
+                else:
+                    messages.add_message(
+                        request, messages.SUCCESS,
+                        _('Publication date unset')
                     )
-                )
-
             else:
                 messages.add_message(
                     request, messages.WARNING,

diff --git a/src/submission/forms.py b/src/submission/forms.py
@@ -539,3 +539,4 @@ def save(self, commit=True):
             )
             article.fixedpubcheckitems.save()
             article.save()
+        return article