chrore: migration to hardhat + enabled external tx signers (#488)

* wip: defender deployer

* wip

* wip

* fix deployment args

* wip - sha3 is failing

* test sha3

* extension configuration call fixed

* hardhat deployment fixed

* added log-util + file reorg

* added readme badgers

* fix tests - wip

* fixed all tests to work with truffle

* update package.json + fix test libs

* fix test workflow

* updated node v for workflows + lint cfgs

* fix lint

* fix coverage task

* reorg configs

Signed-off-by: Felipe Forbeck <[email protected]>

* fix workflows

* Revert "reorg configs"

This reverts commit c1f0459.

* fix pkg reorg

* update pkg json + prettier

* fix imports

* update package-lock

* fix coverage task

* wip - verify contracts

* fixed verification script

* wip - defender provider

* wip: defender provider

* wip: defender provider

* added googleKms signer

* deploying with gcp kms signer

* minor fixes

* renamed pkg

* set configs

* update pr template

* wip dao artifacts

* fix dao artifacts

* fix ganache deployment

* fix slither task and readme

* Update utils/log-util.js

* Update tasks/deploy.js

* fix lint

* update slither workflow

* removed migrations dir

* removed website dir

* removed docs workflow

* update readme

.github/PULL_REQUEST_TEMPLATE.md

@@ -1,7 +1,5 @@
-Fixes #
-
 ## Proposed Changes
 
--
+- ...
 -
 -

.github/workflows/coverage.yml

@@ -7,6 +7,9 @@ on:
   pull_request:
     branches:
       - "*"
+env:
+  ETH_NODE_URL: ${{ secrets.ETH_NODE_URL }}
+  WALLET_MNEMONIC: ${{ secrets.WALLET_MNEMONIC }}
 
 jobs:
   coverage:
@@ -18,7 +21,7 @@ jobs:
       - name: Setup node
         uses: actions/setup-node@v2
         with:
-          node-version: "14.17.0"
+          node-version: "16.3.0"
 
       - name: Setup SSH to install dependencies
         uses: webfactory/[email protected]
@@ -28,8 +31,8 @@ jobs:
       - name: Install dependencies
         run: npm ci
 
-      - name: Compile Contracts and Check Coverage
-        run: npm run compile && npm run coverage
+      - name: Check Coverage
+        run: npm run coverage
 
       - name: Publish to Codecov.io
         run: bash <(curl -s https://codecov.io/bash) -t ${{ secrets.CODECOV_TOKEN }}

.github/workflows/publish.yml

@@ -4,6 +4,9 @@ on:
     tags:
       - '*'
 
+env:
+  ETH_NODE_URL: ${{ secrets.ETH_NODE_URL }}
+
 jobs:
   publish:
     runs-on: ubuntu-20.04
@@ -14,7 +17,7 @@ jobs:
       - name: Setup node
         uses: actions/setup-node@v2
         with:
-          node-version: "14.17.0"
+          node-version: "16.3.0"
 
       - name: Setup SSH to install dependencies
         uses: webfactory/[email protected]

.github/workflows/slither.yml

@@ -11,6 +11,10 @@ on:
       - "*"
     paths:
       - "contracts/**"
+
+env:
+  ETH_NODE_URL: ${{ secrets.ETH_NODE_URL }}
+
 jobs:
   slither:
     name: Slither Analysis
@@ -23,7 +27,7 @@ jobs:
       - name: Setup node
         uses: actions/setup-node@v2
         with:
-          node-version: "14.17.0"
+          node-version: "16.3.0"
 
       - name: Setup SSH to install dependencies
         uses: webfactory/[email protected]
@@ -33,6 +37,9 @@ jobs:
       - name: Install NPM dependencies
         run: npm ci
 
+      - name: Compile Contracts
+        run: npm run compile
+
       - name: Setup Python 3.7
         uses: actions/setup-python@v2
         with:
@@ -45,8 +52,8 @@ jobs:
       
       - name: Summary of static analysis
         run: |
-          slither . --print human-summary
+          slither . --print human-summary --ignore-compile --hardhat-artifacts-directory ./build/artifacts --config-file slither.config.json
 
       - name: High/Med/Low issues
         run: |
-          slither . --config-file slither.config.json
+          slither . --ignore-compile --hardhat-artifacts-directory ./build/artifacts --config-file slither.config.json

.github/workflows/test.yml

@@ -8,6 +8,9 @@ on:
     branches:
       - "*"
 
+env:
+  ETH_NODE_URL: ${{ secrets.ETH_NODE_URL }}
+
 jobs:
   test:
     runs-on: ubuntu-20.04
@@ -18,7 +21,7 @@ jobs:
       - name: Setup node
         uses: actions/setup-node@v2
         with:
-          node-version: "14.17.0"
+          node-version: "16.3.0"
 
       - name: Setup SSH to install dependencies
         uses: webfactory/[email protected]
@@ -32,4 +35,4 @@ jobs:
         run: npm run lint
 
       - name: Compile Contracts and Run Tests
-        run: npm run compile && npm run test
+        run: npm test

.gitignore

@@ -4,6 +4,7 @@ npm-debug.log*
 yarn-debug.log*
 yarn-error.log*
 lerna-debug.log*
+.history/
 
 # Diagnostic reports (https://nodejs.org/api/report.html)
 report.[0-9]*.[0-9]*.[0-9]*.[0-9]*.json

.prettierignore

@@ -0,0 +1,4 @@
+coverage/
+build/
+logs/
+.vscode/

.solcover.js

@@ -2,7 +2,7 @@ module.exports = {
   norpc: true,
   measureStatementCoverage: true,
   measureFunctionCoverage: true,
-  testCommand: "npm run test",
+  testCommand: "npm test",
   compileCommand: "npm run compile",
   providerOptions: {
     default_balance_ether: "10000000000000000000000000",

.solhint.json

@@ -1,16 +1,15 @@
-{
+{ 
   "extends": "solhint:recommended",
   "rules": {
-    "func-order": "off",
-    "mark-callable-contracts": "off",
     "no-empty-blocks": "off",
+    "no-inline-assembly": "warn",
+    "func-order": "warn",
+    "func-param-name-mixedcase": "error",
     "compiler-version": ["error", "^0.8.0"],
-    "private-vars-leading-underscore": "error",
-    "reason-string": "on",
-    "no-unused-vars": "warn",
-    "payable-fallback": "error",
+    "mark-callable-contracts": "off",
     "reentrancy": "error",
     "code-complexity": ["warn", 7],
-    "no-inline-assembly": "warn"
+    "private-vars-leading-underscore": "error",
+    "modifier-name-mixedcase": "error"
   }
 }