Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation fix, GitError exception instantiation fixes #387

Merged
merged 4 commits into from
Feb 6, 2024

Conversation

renatav
Copy link
Collaborator

@renatav renatav commented Feb 3, 2024

Description (e.g. "Related to ...", etc.)

  • When only validating repositories, validation would fail if there were no local branches. Commits can still be listed given a remote branch. Local branches do not exist after a repository is cloned unless it is checked out.
  • Fix GitError exception instantiation
  • Update find_first_branch_matching_pattern return - only return name of the found branch and not all branches whose name did not match the pattern

Code review checklist (for code reviewer to complete)

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Commit messages are meaningful (see this for details)
  • Tests have been included and/or updated, as appropriate
  • Docstrings have been included and/or updated, as appropriate
  • Changelog has been updated, as needed (see CHANGELOG.md)

…mote does

When only validating repositories, validation would fail if there were
no local branches. Commits can still be listed based given a remote branch.
Local branches do not exist after a repository is cloned unless it is checked out.
@renatav renatav marked this pull request as ready for review February 6, 2024 19:14
@renatav renatav requested a review from n-dusan February 6, 2024 19:29
@renatav renatav merged commit e18d99d into master Feb 6, 2024
20 of 25 checks passed
@renatav renatav deleted the renatav/validation-improvements branch February 6, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants