Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bojangalic/Add git command functionality into serve command, and keep both commands #65

Merged
merged 9 commits into from
Feb 5, 2025

Conversation

BojanG99
Copy link
Contributor

Related to #54

Git command isn't deleted here since we want to ensure smooth transition on servers. Deleting it now would break current setup.

Code review checklist (for code reviewer to complete)

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Commit messages are meaningful (see this for details)
  • Tests have been included and/or updated, as appropriate
  • Docstrings have been included and/or updated, as appropriate
  • Standalone docs have been updated accordingly

Automated tests, benchmarks and linters

You can run the tests, lints and benchmarks that are run on CI locally with:

just ci

Sorry, something went wrong.

@BojanG99 BojanG99 changed the title Bojangalic/return git command Bojangalic/Add git command functionality into serve command, and keep both commands Jan 22, 2025
Copy link
Contributor

@n-dusan n-dusan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a question. Would be awesome if we were able to simplify. Let me know what you think. I believe we can close out #64 in favor of this pr?

@n-dusan n-dusan self-requested a review February 5, 2025 11:56
n-dusan
n-dusan previously approved these changes Feb 5, 2025
Copy link
Contributor

@n-dusan n-dusan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment. I believe we can resolve in a separate pr (where we add docs)

@BojanG99 BojanG99 force-pushed the bojangalic/returnGitCommand branch from ce6e487 to 85f1a46 Compare February 5, 2025 14:41
@n-dusan n-dusan self-requested a review February 5, 2025 14:47
Copy link
Contributor

@n-dusan n-dusan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@BojanG99 BojanG99 merged commit 6ae88ac into main Feb 5, 2025
4 checks passed
@n-dusan n-dusan deleted the bojangalic/returnGitCommand branch February 5, 2025 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants