-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bojangalic/Add git command functionality into serve command, and keep both commands #65
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a question. Would be awesome if we were able to simplify. Let me know what you think. I believe we can close out #64 in favor of this pr?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small comment. I believe we can resolve in a separate pr (where we add docs)
d333605
to
f107a5e
Compare
…it also as separate command since its removal will break current setup
…d added docker file for cross compiling of stelae
ce6e487
to
85f1a46
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
Related to #54
Git command isn't deleted here since we want to ensure smooth transition on servers. Deleting it now would break current setup.
Code review checklist (for code reviewer to complete)
Automated tests, benchmarks and linters
You can run the tests, lints and benchmarks that are run on CI locally with: