Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Parse recursive stele #57

Merged
merged 5 commits into from
Nov 20, 2024
Merged

feat: Parse recursive stele #57

merged 5 commits into from
Nov 20, 2024

Conversation

n-dusan
Copy link
Contributor

@n-dusan n-dusan commented Nov 13, 2024

Description (e.g. "Related to ...", etc.)

  • Update multi-host tests that verify recursive stele's are resolved.
  • Add visitor to avoid cycles during parse.
    • Add test to verify cycles are resolved.
  • Fix GitHub tokens.

Code review checklist (for code reviewer to complete)

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Commit messages are meaningful (see this for details)
  • Tests have been included and/or updated, as appropriate
  • Docstrings have been included and/or updated, as appropriate
  • Standalone docs have been updated accordingly

Automated tests, benchmarks and linters

You can run the tests, lints and benchmarks that are run on CI locally with:

just ci

@n-dusan
refact: rename api module names
8d7943b 
They all start with archive. Will add more to this directory
@n-dusan
refact(test): confirm recursive serve works
75017d2 
Update testing framework to test against child steles which are
dependencies of dependencies. E.g. stele_1 -> stele_1_1 resolves
correctly.
@n-dusan
feat: avoid cycles during stelae parse
0740515 
Add a simple visitor that checks whether the current stele has already
been parsed.
@n-dusan
feat(test): test for cycles
078e4fd 
Expect that cycles are correctly accounted for and resolved.
Programatically introduce a cycle with `stele_1 -> stele_1_1 -> stele_1`
through dependencies.json.
@n-dusan
fix: fix tokens on CI
d41f0dc 
- Omit unnecessary GitHub tokens.
- Pass in default GITHUB_TOKEN instead of using custom
  STELAE_GITHUB_TOKEN.
@n-dusan n-dusan requested a review from dgreisen November 13, 2024 21:51
@n-dusan n-dusan self-assigned this Nov 13, 2024
@n-dusan n-dusan merged commit e5a2f10 into main Nov 20, 2024
12 checks passed
@n-dusan n-dusan deleted the ndusan/parse-recursive-stele branch November 20, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgreisen dgreisen dgreisen approved these changes

Assignees

@n-dusan n-dusan

Labels
security
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@n-dusan @dgreisen