fix: load paths to git repositories at start-time; versions endpoint fix #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also reduce nesting by early exiting the function if conditions aren't met.
- Moved `find_blob` to `git/utils/mod.rs` module as `Repo` associated function. - Refactor `RepoState` and `FallbackState` to not keep open handles to git repositories. This change makes it so that stelae can serve partial stele, and not fail if any data repository is missing from `repositories.json`. Handles to git repos are now open at request time instead.
tombh
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes to stelae we found on our testing environment.
Two notable changes:
_compareendpoint to not include an additionalcurrentdate if the request url contains/current.stelae servecommand is changed to load paths to git repositories instead of keeping git repository handles open. This makes it so that the command won't fail in cases where data repos aren't on disk. Moreover, if/when data repositories become available on disk,stelae servewill work.