Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout Editor: Fix invisible bottom part of the screen #3033

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

jimtng
Copy link
Contributor

@jimtng jimtng commented Jan 22, 2025

In non full-screen mode, the bottom of the screen was hidden behind the bottom toolbar. This includes the "Add Masonry" button and any components at the bottom of the screen.

Notice the missing "Add Masonry" button
image

Copy link

relativeci bot commented Jan 22, 2025

#2742 Bundle Size — 10.98MiB (~+0.01%).

1fa9e4a(current) vs bb669d8 main#2741(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
#2742
     Baseline
#2741
Regression  Initial JS 1.9MiB(~+0.01%) 1.9MiB
No change  Initial CSS 577.21KiB 577.21KiB
Change  Cache Invalidation 17.51% 18.33%
No change  Chunks 227 227
No change  Assets 250 250
No change  Modules 2952 2952
No change  Duplicate Modules 154 154
No change  Duplicate Code 1.8% 1.8%
No change  Packages 98 98
No change  Duplicate Packages 2 2
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#2742
     Baseline
#2741
Regression  JS 9.19MiB (~+0.01%) 9.19MiB
No change  CSS 867.33KiB 867.33KiB
No change  Fonts 526.1KiB 526.1KiB
No change  Media 295.6KiB 295.6KiB
No change  IMG 140.74KiB 140.74KiB
No change  HTML 1.38KiB 1.38KiB
No change  Other 871B 871B

Bundle analysis reportBranch jimtng:layout-bottom-marginProject dashboard


Generated by RelativeCIDocumentationReport issue

@jimtng jimtng force-pushed the layout-bottom-margin branch from 262f318 to d5b51a7 Compare January 22, 2025 02:20
In non full-screen mode, the bottom of the screen was hidden behind the bottom toolbar. This includes the "Add Masonry" button and any components at the bottom of the screen.

Signed-off-by: Jimmy Tanagra <[email protected]>
@jimtng jimtng force-pushed the layout-bottom-margin branch from d5b51a7 to a159bcc Compare January 22, 2025 02:32
@florian-h05
Copy link
Contributor

I have just pushed a commit that fixes another styling issue on the layout page editor:

image

to

image

@florian-h05 florian-h05 added bug Something isn't working main ui Main UI labels Jan 23, 2025
@florian-h05 florian-h05 added this to the 5.0 milestone Jan 23, 2025
Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@florian-h05 florian-h05 merged commit 95844d2 into openhab:main Jan 23, 2025
5 checks passed
@jimtng jimtng deleted the layout-bottom-margin branch January 23, 2025 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants