Don't subscribe to Item events to reload model #2949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids that the global SSE connection is always established, and therefore reduces problems with the max parallel HTTP connections limitation. The global SSE connection is now only established if the web audio sink or the command Item are enabled. Whilst this change potentially makes the UI not reload the model automatically on change, practically the now removed mechanism might haven't been really useful at all because the model is already reloaded on Main UI start, and if SSE was not connected the moment an Item changed the mechanism did not trigger. Signed-off-by: Florian Hotze <[email protected]>
florian-h05
changed the title
#2601 Bundle Size — 10.9MiB (~-0.01%).86b04f1(current) vs df02810 main#2600(baseline) Warning Bundle contains 2 duplicate packages – View duplicate packages Bundle metrics
|
| Current #2601 |
Baseline #2600 |
|
|---|---|---|
 Initial JS |
1.9MiB(-0.01%) |
1.9MiB |
 Initial CSS |
577.39KiB |
577.39KiB |
 Cache Invalidation |
17.43% |
17.42% |
| Chunks |
226 |
226 |
| Assets |
249 |
249 |
| Modules |
2947 |
2947 |
| Duplicate Modules |
154 |
154 |
| Duplicate Code |
1.8% |
1.8% |
| Packages |
96 |
96 |
| Duplicate Packages |
2 |
2 |
Bundle size by type 1 change 1 improvement
| Current #2601 |
Baseline #2600 |
|
|---|---|---|
| JS |
9.11MiB (~-0.01%) |
9.11MiB |
| CSS |
866.47KiB |
866.47KiB |
| Fonts |
526.1KiB |
526.1KiB |
| Media |
295.6KiB |
295.6KiB |
| IMG |
140.74KiB |
140.74KiB |
| HTML |
1.38KiB |
1.38KiB |
| Other |
871B |
871B |
Bundle analysis report Branch florian-h05:semantic-model-no-ss... Project dashboard
Generated by RelativeCI Documentation Report issue
florian-h05
added a commit
that referenced
this pull request
Dec 28, 2024
Related to #2584 and openhab/openhab-core#4466. This avoids that the global SSE connection is always established, and therefore reduces problems with the max parallel HTTP connections limitation. The global SSE connection is now only established if the web audio sink or the command Item are enabled. Whilst this change potentially makes the UI not reload the model automatically on change, practically the now removed mechanism might haven't been really useful at all because the model is already reloaded on Main UI start, and if SSE was not connected the moment an Item changed the mechanism did not trigger. Signed-off-by: Florian Hotze <[email protected]> (cherry picked from commit 5d7f35a)
florian-h05
added
the
patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2584 and openhab/openhab-core#4466.
This avoids that the global SSE connection is always established, and therefore reduces problems with the max parallel HTTP connections limitation. The global SSE connection is now only established if the web audio sink or the command Item are enabled.
Whilst this change potentially makes the UI not reload the model automatically on change, practically the now removed mechanism might haven't been really useful at all because the model is already reloaded on Main UI start, and if SSE was not connected the moment an Item changed the mechanism did not trigger.