minor cleaning

src/ralph/api/auth/basic.py

@@ -13,7 +13,7 @@
 from pydantic import BaseModel, root_validator
 from starlette.authentication import AuthenticationError
 
-from ralph.api.auth.user import AuthenticatedUser, UserScopes
+from ralph.api.auth.user import AuthenticatedUser
 from ralph.conf import settings
 
 # Unused password used to avoid timing attacks, by comparing passwords supplied
@@ -188,8 +188,7 @@ def get_basic_auth_user(
     # Restrict access by scopes
     if settings.LRS_RESTRICT_BY_SCOPES:
         for requested_scope in security_scopes.scopes:
-            is_auth = user.scopes.is_authorized(requested_scope)
-            if not is_auth:
+            if not user.scopes.is_authorized(requested_scope):
                 raise HTTPException(
                     status_code=status.HTTP_401_UNAUTHORIZED,
                     detail=f'Access not authorized to scope: "{requested_scope}".',

src/ralph/api/auth/oidc.py

@@ -153,8 +153,7 @@ def get_oidc_user(
     # Restrict access by scopes
     if settings.LRS_RESTRICT_BY_SCOPES:
         for requested_scope in security_scopes.scopes:
-            is_auth = user.scopes.is_authorized(requested_scope)
-            if not is_auth:
+            if not user.scopes.is_authorized(requested_scope):
                 raise HTTPException(
                     status_code=status.HTTP_401_UNAUTHORIZED,
                     detail=f'Access not authorized to scope: "{requested_scope}".',

src/ralph/api/auth/user.py

@@ -3,8 +3,6 @@
 from functools import lru_cache
 from typing import Dict, FrozenSet, Literal
 
-from ralph.conf import settings
-
 from pydantic import BaseModel
 
 Scope = Literal[
@@ -58,11 +56,13 @@ def is_authorized(self, requested_scope: Scope):
 
     @classmethod
     def __get_validators__(cls):  # noqa: D105
-        def validate(value: FrozenSet[Scope]) -> UserScopes:
+        def validate(value: FrozenSet[Scope]):
             """Transform value to an instance of UserScopes."""
             return cls(value)
+
         yield validate
 
+
 class AuthenticatedUser(BaseModel):
     """Pydantic model for user authentication.