Catch error and provide message #13115
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mkllnk , can you please review the error above, and let me know if I'm on the right track? If so, I'll go ahead and add a spec (I think a spec request would be sufficient) |
mkllnk
reviewed
Feb 5, 2025
Comment on lines
+8
to
13
| rescue ActiveRecord::RecordNotUnique | ||
| flash[:error] = t("devise.oidc.record_not_unique", uid: request.env["omniauth.auth"].uid) | ||
| redirect_to admin_oidc_settings_path | ||
| end |
dacook
force-pushed
the
oidc-record-not-unique
branch
from
faa7abd to
61d0df1
Compare
Oh, and a transaction block. Because the controller after hooks tried to update the DB which resulted in PG::InFailedSqlTransaction: ERROR: current transaction is aborted, commands ignored until end of transaction block Even for a small rescue statement, it's worth adding a spec. You never know what might not be working!
dacook
force-pushed
the
oidc-record-not-unique
branch
from
61d0df1 to
f6f1a00
Compare
dacook
added
the
technical changes only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
What should we test?
Release notes
Changelog Category (reviewers may add a label for the release notes):
The title of the pull request will be included in the release notes.
Dependencies
Documentation updates