-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add course enrollment sink #64
Conversation
Thanks for the pull request, @Ian2012! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
7cdafc2
to
74d814b
Compare
f30febd
to
9f4cd69
Compare
a083899
to
452c966
Compare
452c966
to
3e788ff
Compare
@Ian2012 - i enrolled/unenrolled and also ran the dump to clickhouse. It looks like the ID values are not unique, is that expected? Also, it doesn't seem to differentiate between enroll and unenroll, do we need that info? |
@saraburns1 Yes, the IDs correspond to the record on the DB and it's expected to be duplicated. We will create an MV that stores the last records per learner per course and their status. Tracking logs will be available for historical records. This will only be used to backfill data from the enrollments and know their last state. I think we can calculate enroll/unenroll with the |
@Ian2012 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Description
This PR creates a sink for the Course Enrollment mode. It uses the
ENROLL_STATUS_CHANGE
signal to listen for changes in enrollments.Testing instructions
event_sink_clickhouse.course_enrollment.enabled
.dump_data_to_clickhouse
can dump old data.Merge checklist:
Check off if complete or not applicable: