-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: serialize datetime objects as strings #52
Conversation
Thanks for the pull request, @Ian2012! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
I'd rather not bring in event-tracking and all of its sub-dependencies just for this one small class that has basically not changed in 11 yrs. I'd rather just copy it in, or use an altered version of the accepted SO answer with the addition of the very good UTC changes from event-tracking. |
170b6bc
to
f04b5ce
Compare
chore: quality fixes chore: remove print statement chore: quality fixes refactor: do not use eventtracking date serializer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@Ian2012 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Description
This PR fixes an issue when serializing as JSON the course data where some attributes were dates cannot be encoded by default. We use the code from
event-tracking
to allow the serialization of datetime objects as JSON.