Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix slug repeating language and change tab name #33

Merged
merged 3 commits into from
Apr 17, 2024

Conversation

bmtcril
Copy link
Contributor

@bmtcril bmtcril commented Apr 16, 2024

After these changes embedded dashboards should load again. It is currently expected that there will be dataset errors showing up and some data may not appear, that's being worked on elsewhere.

Merge checklist:
Check off if complete or not applicable:

  • Version bumped
  • Changelog record added
  • Documentation updated (not only docstrings)
  • Fixup commits are squashed away
  • Unit tests added/updated
  • Manual testing instructions provided
  • Noted any: Concerns, dependencies, migration issues, deadlines, tickets

@bmtcril bmtcril force-pushed the bmtcril/lms_dash_fixes branch from 5767af9 to f13f365 Compare April 17, 2024 13:28
Copy link

github-actions bot commented Apr 17, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  platform_plugin_aspects
  __init__.py
  utils.py
Project Total  

This report was generated by python-coverage-comment-action

@bmtcril bmtcril requested review from Ian2012 and pomegranited April 17, 2024 13:45
@bmtcril bmtcril force-pushed the bmtcril/lms_dash_fixes branch from 1fcd399 to 2150f0e Compare April 17, 2024 14:17
Copy link
Contributor

@Ian2012 Ian2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a minor change of when the dashboard_uuids are generated

@Ian2012 Ian2012 merged commit fd33392 into main Apr 17, 2024
7 checks passed
@Ian2012 Ian2012 deleted the bmtcril/lms_dash_fixes branch April 17, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants