feat: allow embedding multiple superset dashboards #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @Ian2012! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Ian2012
force-pushed
the
cag/multiple-dashboards
branch
from
24bfc02 to
dee2365
Compare
Ian2012
force-pushed
the
cag/multiple-dashboards
branch
from
73dd369 to
a3b8e9c
Compare
Ian2012
force-pushed
the
cag/multiple-dashboards
branch
from
a3b8e9c to
a642e34
Compare
pomegranited
approved these changes
Mar 20, 2024
There was a problem hiding this comment.
👍 -- works great, looks lovely!
- I tested this by checking the tabbed Instructor Dashboard plugin.
Found a minor issue with the XBlock: fix: xblock not rendering correctly when no dashboard_uuid is set #16 - I read through the code
-
I checked for accessibility issuesN/A -
Includes documentationN/A - User-facing strings are extracted for translation - or configurable.
bmtcril
approved these changes
Mar 20, 2024
fix: xblock not rendering correctly when no dashboard_uuid is set
|
@Ian2012 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR allows embedding multiple superset dashboards in the LMS instructor dashboard.
Tested against: openedx/tutor-contrib-aspects#666
Screenshots