-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BD-46] fix: default color for not valid value #2715
Conversation
✅ Deploy Preview for paragon-openedx ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Thanks for the pull request, @khudym! When this pull request is ready, tag your edX technical lead. |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2715 +/- ##
==========================================
+ Coverage 91.83% 92.82% +0.99%
==========================================
Files 235 235
Lines 4225 4238 +13
Branches 1025 1029 +4
==========================================
+ Hits 3880 3934 +54
+ Misses 341 300 -41
Partials 4 4
☔ View full report in Codecov by Sentry. |
e326fb2
to
4622b17
Compare
@khudym can we also update initial state variables on the docs site? Replace empty strings with valid colors, otherwise we get a brief Screen.Recording.2023-10-19.at.09.52.57.mov |
We discussed this in the working group meeting and the conversation there led to a "we shouldn't allow invalid hex" decision. After looking into that a bit more, I don't think "we shouldn't allow invalid hex" is a complete solution to our problem. We need to support at least entering valid hex or an empty string (to allow clearing out the pick), but it gets even more complex than that. The I made a draft PR where I tried to put together what feels to me like desired behavior for this component #2734 |
@brian-smith-tcril Thanks for the context! I really wasn't sure what's going on with this component... I'll take a look at you PR as well. |
Colsing this as the issue was fixed in #2734 |
Description
Add default value for invalid color proposed in PR comments
Issue
Deploy Preview
Include a direct link to your changes in this PR's deploy preview here (e.g., a specific component page).
Merge Checklist
example
app?wittjeff
andadamstankiewicz
as reviewers on this PR.Post-merge Checklist