Skip to content

Commit

Permalink
fix: remove email from subscription license event (#58)
Browse files Browse the repository at this point in the history
  • Loading branch information
rgraber authored May 23, 2022
1 parent 549839e commit ad4754f
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 5 deletions.
6 changes: 6 additions & 0 deletions CHANGELOG.rst
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,12 @@ Unreleased
Changed
~~~~~~~

[0.9.1] - 2022-05-20
--------------------
Changed
~~~~~~~
* Remove assigned_email from SubscriptionLicenseData

[0.9.0] - 2022-04-28
--------------------
Changed
Expand Down
2 changes: 1 addition & 1 deletion openedx_events/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@
more information about the project.
"""

__version__ = "0.9.0"
__version__ = "0.9.1"
4 changes: 1 addition & 3 deletions openedx_events/enterprise/data.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
import attr


# TODO (EventBus): consider how to proactively prevent PII from being sent to kafka
@attr.s(frozen=True)
class SubscriptionLicenseData:
"""
Expand All @@ -27,8 +28,6 @@ class SubscriptionLicenseData:
May be empty.
assigned_lms_user_id (str): The LMS User id of the user that this license 'belongs to'.
May be empty if this license is not activated yet.
assigned_email (str): The email assigned to this license.
Will be empty if this license is not assigned to a learner yet.
expiration_processed (bool): Boolean value of License 'expiration_processed' field, may be True or False.
True means a license is expired.
auto_applied (bool):
Expand All @@ -44,7 +43,6 @@ class SubscriptionLicenseData:
previous_license_uuid = attr.ib(type=str)
assigned_date = attr.ib(type=str)
activation_date = attr.ib(type=str)
assigned_email = attr.ib(type=str)
expiration_processed = attr.ib(type=bool)
assigned_lms_user_id = attr.ib(type=int, default=None)
auto_applied = attr.ib(type=bool, default=False)
Expand Down
2 changes: 1 addition & 1 deletion openedx_events/enterprise/signals.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
# See: https://openedx.atlassian.net/browse/ARCHBOM-2008 for more details.
# .. event_data: SubscriptionLicenseData
SUBSCRIPTION_LICENSE_MODIFIED = OpenEdxPublicSignal(
event_type="org.openedx.enterprise.subscription.license.modified.v1",
event_type="org.openedx.enterprise.subscription.license.modified.v0",
data={
"license": SubscriptionLicenseData,
}
Expand Down

0 comments on commit ad4754f

Please sign in to comment.