Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the links to use MARKETING_SITE_BASE_URL #166

Closed
wants to merge 1 commit into from

Conversation

asadiqbal08
Copy link
Contributor

fixes: mitodl/mitxonline#268

From the menu in MFE in MITx Online edX, there are a couple links that need to be updated.

  • "Dashboard" menu item should link to: MARKETING_SITE_URL/dashboard rather than LMS_BASE_URL/dashboard/
  • "Profile" menu item should link to: MARKETING_SITE/profile rather than LMS_BASE_URL/u/USERNAME
  • Also, in the menu in the 'legacy' theme, clicking on the username will take you to LMS_BASE_URL/dashboard, but should take you to MARKETING_SITE/dashboard

@asadiqbal08 asadiqbal08 requested a review from a team December 21, 2021 11:04
@openedx-webhooks
Copy link

Thanks for the pull request, @asadiqbal08! I've created OSPR-6335 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

⚠️ We can't start reviewing your pull request until you've submitted a signed contributor agreement or indicated your institutional affiliation. Please see the CONTRIBUTING file for more information. If you've signed an agreement in the past, you may need to re-sign. See The New Home of the Open edX Codebase for details.

@openedx-webhooks openedx-webhooks removed the open-source-contribution PR author is not from Axim or 2U label Dec 21, 2021
@openedx-webhooks
Copy link

@asadiqbal08 Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U rejected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Couple of links that need to update
2 participants