-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add customer record card #396
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
81e5d0b
to
a9d69ae
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #396 +/- ##
==========================================
+ Coverage 84.68% 84.74% +0.06%
==========================================
Files 172 174 +2
Lines 3611 3645 +34
Branches 879 880 +1
==========================================
+ Hits 3058 3089 +31
- Misses 539 542 +3
Partials 14 14 ☔ View full report in Codecov by Sentry. |
kiram15
reviewed
Aug 8, 2024
src/Configuration/Customers/CustomerDetailView/CustomerViewContainer.jsx
Outdated
Show resolved
Hide resolved
src/Configuration/Customers/CustomerDetailView/CustomerViewContainer.jsx
Outdated
Show resolved
Hide resolved
src/Configuration/Customers/CustomerDetailView/CustomerCard.jsx
Outdated
Show resolved
Hide resolved
src/Configuration/Customers/CustomerDetailView/CustomerViewContainer.jsx
Show resolved
Hide resolved
a9d69ae
to
8177c21
Compare
kiram15
approved these changes
Aug 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
src/Configuration/Customers/CustomerDetailView/CustomerCard.jsx
Outdated
Show resolved
Hide resolved
8177c21
to
5ce69c9
Compare
5ce69c9
to
75d3c8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As part of the enterprise setup support tool update, we created a customer card with relevant customer info.
UI
Test Plan on Stage
knguyen2/ent-9159
and runnpm install
webpack.dev.config.js
with the following content:.env.development
with this info:https://2u-internal.atlassian.net/browse/ENT-9159