Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add customer record card #396

Merged
merged 3 commits into from
Aug 9, 2024
Merged

feat: add customer record card #396

merged 3 commits into from
Aug 9, 2024

Conversation

katrinan029
Copy link
Contributor

@katrinan029 katrinan029 commented Aug 6, 2024

Description

As part of the enterprise setup support tool update, we created a customer card with relevant customer info.

UI

Screenshot 2024-08-07 at 12 22 06 PM

Test Plan on Stage

  1. checkout branch knguyen2/ent-9159 and run npm install
  2. at the root directory, add file webpack.dev.config.js with the following content:
const { createConfig } = require('@edx/frontend-build');

module.exports = createConfig('webpack-dev', {
  devServer: {
    allowedHosts: 'all',
    https: true,
  },
});
  1. replace the content in .env.development with this info:
NODE_ENV='development'
PORT=18450
FEATURE_CUSTOMER_SUPPORT_VIEW='true'
ADMIN_PORTAL_BASE_URL='https://portal.stage.edx.org'
ACCESS_TOKEN_COOKIE_NAME='stage-edx-jwt-cookie-header-payload'
BASE_URL='https://localhost.stage.edx.org:18450'
FEATURE_CONFIGURATION_MANAGEMENT='true'
FEATURE_CONFIGURATION_ENTERPRISE_PROVISION='true'
FEATURE_CONFIGURATION_EDIT_ENTERPRISE_PROVISION='true'
CREDENTIALS_BASE_URL='https://credentials.stage.edx.org'
CSRF_TOKEN_API_PATH='/csrf/api/v1/token'
ECOMMERCE_BASE_URL='https://ecommerce.stage.edx.org'
ENTERPRISE_ACCESS_BASE_URL='https://enterprise-access.stage.edx.org'
LANGUAGE_PREFERENCE_COOKIE_NAME='openedx-language-preference'
LMS_BASE_URL='https://courses.stage.edx.org'
LICENSE_MANAGER_URL='https://license-manager.stage.edx.org'
SUPPORT_CONFLUENCE='https://support-tools.edx.org'
SUPPORT_CUSTOMER_REQUEST='https://support-tools.edx.org'
DISCOVERY_API_BASE_URL='https://discovery.stage.edx.org'
LOGIN_URL='https://courses.stage.edx.org/login'
LOGOUT_URL='https://courses.stage.edx.org/logout'
LOGO_URL=https://edx-cdn.org/v3/default/logo.svg
LOGO_TRADEMARK_URL=https://edx-cdn.org/v3/default/logo-trademark.svg
LOGO_WHITE_URL=https://edx-cdn.org/v3/default/logo-white.svg/
FAVICON_URL=https://edx-cdn.org/v3/default/favicon.ico
MARKETING_SITE_BASE_URL='https://stage.edx.org'
ORDER_HISTORY_URL='https://orders.stage.edx.org/orders'
REFRESH_ACCESS_TOKEN_ENDPOINT='https://courses.stage.edx.org/login_refresh'
SEGMENT_KEY=null
SITE_NAME='edX'
SUBSIDY_BASE_URL='https://enterprise-subsidy.stage.edx.org'
USER_INFO_COOKIE_NAME='edx-user-info'
PUBLISHER_BASE_URL='https://publisher.stage.edx.org/'
APP_ID='support-tools'
MFE_CONFIG_API_URL='https://courses.stage.edx.org/api/mfe_config/v1'
  1. verify that you can see the customer card that matches figma: https://www.figma.com/design/TP5hGfoYmohr21MwgUgCZN/Enterprise-Setup?node-id=914-16353&t=3Fs3hMg0TNnSl7Lv-0
  2. verify that clicking on the open in django will take you to the customer's django admin screen. the 'view details' button is currently a no-op.

https://2u-internal.atlassian.net/browse/ENT-9159

@katrinan029 katrinan029 changed the title Knguyen2/ent 9159 feat: add customer record card Aug 6, 2024
@katrinan029 katrinan029 marked this pull request as ready for review August 6, 2024 20:30
@katrinan029 katrinan029 force-pushed the knguyen2/ent-9159 branch 2 times, most recently from 81e5d0b to a9d69ae Compare August 7, 2024 19:17
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

Attention: Patch coverage is 85.29412% with 5 lines in your changes missing coverage. Please review.

Project coverage is 84.74%. Comparing base (e541f84) to head (8177c21).

Files Patch % Lines
...tion/Customers/CustomerDetailView/CustomerCard.jsx 60.00% 4 Missing ⚠️
...omers/CustomerDetailView/CustomerViewContainer.jsx 94.73% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #396      +/-   ##
==========================================
+ Coverage   84.68%   84.74%   +0.06%     
==========================================
  Files         172      174       +2     
  Lines        3611     3645      +34     
  Branches      879      880       +1     
==========================================
+ Hits         3058     3089      +31     
- Misses        539      542       +3     
  Partials       14       14              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kiram15 kiram15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@katrinan029 katrinan029 merged commit 81ac21f into master Aug 9, 2024
5 checks passed
@katrinan029 katrinan029 deleted the knguyen2/ent-9159 branch August 9, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants