-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add enterprise customer list view #393
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0b6d591
to
9dacf93
Compare
bf82063
to
1c7f1dd
Compare
d1e6bd6
to
dee712f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #393 +/- ##
==========================================
- Coverage 85.23% 84.68% -0.55%
==========================================
Files 164 172 +8
Lines 3467 3611 +144
Branches 858 868 +10
==========================================
+ Hits 2955 3058 +103
- Misses 502 539 +37
- Partials 10 14 +4 ☔ View full report in Codecov by Sentry. |
kiram15
reviewed
Aug 5, 2024
src/Configuration/Customers/CustomerDataTable/CustomerDetails.jsx
Outdated
Show resolved
Hide resolved
src/Configuration/Customers/CustomerDataTable/CustomerDetailSubComponent.jsx
Outdated
Show resolved
Hide resolved
dee712f
to
31aa077
Compare
kiram15
approved these changes
Aug 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As part of the enterprise setup support tool update, we need to update the drop down menu selection to add “Customers” that links to a datatable with customer detail information.
Screen.Recording.2024-08-02.at.11.03.22.AM.mov
Test Plan on Stage
knguyen2/ent-9156
and runnpm install
webpack.dev.config.js
with the following content:.env.development
with this info:Customer
link in the drop down menuhttps://2u-internal.atlassian.net/browse/ENT-9156