Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add enterprise customer list view #393

Merged
merged 2 commits into from
Aug 6, 2024
Merged

Conversation

katrinan029
Copy link
Contributor

@katrinan029 katrinan029 commented Aug 2, 2024

Description

As part of the enterprise setup support tool update, we need to update the drop down menu selection to add “Customers” that links to a datatable with customer detail information.

Screen.Recording.2024-08-02.at.11.03.22.AM.mov

Test Plan on Stage

  1. checkout branch knguyen2/ent-9156 and run npm install
  2. at the root directory, add file webpack.dev.config.js with the following content:
const { createConfig } = require('@edx/frontend-build');

module.exports = createConfig('webpack-dev', {
  devServer: {
    allowedHosts: 'all',
    https: true,
  },
});
  1. replace the content in .env.development with this info:
NODE_ENV='development'
PORT=18450
FEATURE_CUSTOMER_SUPPORT_VIEW='true'
ADMIN_PORTAL_BASE_URL='https://portal.stage.edx.org'
ACCESS_TOKEN_COOKIE_NAME='stage-edx-jwt-cookie-header-payload'
BASE_URL='https://localhost.stage.edx.org:18450'
FEATURE_CONFIGURATION_MANAGEMENT='true'
FEATURE_CONFIGURATION_ENTERPRISE_PROVISION='true'
FEATURE_CONFIGURATION_EDIT_ENTERPRISE_PROVISION='true'
CREDENTIALS_BASE_URL='https://credentials.stage.edx.org'
CSRF_TOKEN_API_PATH='/csrf/api/v1/token'
ECOMMERCE_BASE_URL='https://ecommerce.stage.edx.org'
ENTERPRISE_ACCESS_BASE_URL='https://enterprise-access.stage.edx.org'
LANGUAGE_PREFERENCE_COOKIE_NAME='openedx-language-preference'
LMS_BASE_URL='https://courses.stage.edx.org'
LICENSE_MANAGER_URL='https://license-manager.stage.edx.org'
SUPPORT_CONFLUENCE='https://support-tools.edx.org'
SUPPORT_CUSTOMER_REQUEST='https://support-tools.edx.org'
DISCOVERY_API_BASE_URL='https://discovery.stage.edx.org'
LOGIN_URL='https://courses.stage.edx.org/login'
LOGOUT_URL='https://courses.stage.edx.org/logout'
LOGO_URL=https://edx-cdn.org/v3/default/logo.svg
LOGO_TRADEMARK_URL=https://edx-cdn.org/v3/default/logo-trademark.svg
LOGO_WHITE_URL=https://edx-cdn.org/v3/default/logo-white.svg/
FAVICON_URL=https://edx-cdn.org/v3/default/favicon.ico
MARKETING_SITE_BASE_URL='https://stage.edx.org'
ORDER_HISTORY_URL='https://orders.stage.edx.org/orders'
REFRESH_ACCESS_TOKEN_ENDPOINT='https://courses.stage.edx.org/login_refresh'
SEGMENT_KEY=null
SITE_NAME='edX'
SUBSIDY_BASE_URL='https://enterprise-subsidy.stage.edx.org'
USER_INFO_COOKIE_NAME='edx-user-info'
PUBLISHER_BASE_URL='https://publisher.stage.edx.org/'
APP_ID='support-tools'
MFE_CONFIG_API_URL='https://courses.stage.edx.org/api/mfe_config/v1'
  1. verify that you can see the Customer link in the drop down menu
  2. verify that you can search by customer name
  3. verify that the customer name links to the admin portal
  4. verify that you can copy the uuid
  5. verify that you can click on the expand button for the customer row and see an expanded row.

https://2u-internal.atlassian.net/browse/ENT-9156

@katrinan029 katrinan029 force-pushed the knguyen2/ent-9156 branch 2 times, most recently from 0b6d591 to 9dacf93 Compare August 2, 2024 17:54
@katrinan029 katrinan029 marked this pull request as ready for review August 2, 2024 17:57
@katrinan029 katrinan029 force-pushed the knguyen2/ent-9156 branch 3 times, most recently from bf82063 to 1c7f1dd Compare August 2, 2024 19:40
@katrinan029 katrinan029 force-pushed the knguyen2/ent-9156 branch 4 times, most recently from d1e6bd6 to dee712f Compare August 2, 2024 20:04
Copy link

codecov bot commented Aug 3, 2024

Codecov Report

Attention: Patch coverage is 70.06803% with 44 lines in your changes missing coverage. Please review.

Project coverage is 84.68%. Comparing base (4382569) to head (31aa077).

Files Patch % Lines
...n/Customers/data/hooks/useActiveAssociatedPlans.js 3.33% 25 Missing and 4 partials ⚠️
src/index.jsx 0.00% 4 Missing ⚠️
src/supportHeader/Header.jsx 0.00% 4 Missing ⚠️
...tion/Customers/CustomerDataTable/CustomersPage.jsx 88.88% 2 Missing ⚠️
src/data/services/EcommerceApiService.js 83.33% 2 Missing ⚠️
src/data/services/EnterpriseApiService.js 50.00% 2 Missing ⚠️
...on/Customers/CustomerDataTable/CustomerDetails.jsx 96.15% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #393      +/-   ##
==========================================
- Coverage   85.23%   84.68%   -0.55%     
==========================================
  Files         164      172       +8     
  Lines        3467     3611     +144     
  Branches      858      868      +10     
==========================================
+ Hits         2955     3058     +103     
- Misses        502      539      +37     
- Partials       10       14       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kiram15 kiram15 self-requested a review August 5, 2024 20:31
Copy link
Contributor

@kiram15 kiram15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@katrinan029 katrinan029 merged commit e541f84 into master Aug 6, 2024
5 of 7 checks passed
@katrinan029 katrinan029 deleted the knguyen2/ent-9156 branch August 6, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants