Merge pull request #276 from openedx/jhynes/aper-1975_redirect

fix: don't generate frontend specific urls for the Learner Record MFE
openedx · Oct 19, 2022 · 198e04d · 198e04d
2 parents 44f8f12 + e307d69
commit 198e04d
Show file tree

Hide file tree

Showing 6 changed files with 2 additions and 7 deletions.
diff --git a/.env b/.env
@@ -14,7 +14,6 @@ LOGIN_URL=null
 LOGOUT_URL=null
 MARKETING_SITE_BASE_URL=null
 ORDER_HISTORY_URL=null
-RECORDS_BASE_URL=null
 REFRESH_ACCESS_TOKEN_ENDPOINT=null
 SEGMENT_KEY=null
 SITE_NAME=null

diff --git a/.env.development b/.env.development
@@ -19,7 +19,6 @@ LOGO_WHITE_URL=https://edx-cdn.org/v3/default/logo-white.svg/
 FAVICON_URL=https://edx-cdn.org/v3/default/favicon.ico
 MARKETING_SITE_BASE_URL='http://localhost:18000'
 ORDER_HISTORY_URL='localhost:1996/orders'
-RECORDS_BASE_URL='localhost:1990'
 REFRESH_ACCESS_TOKEN_ENDPOINT='http://localhost:18000/login_refresh'
 SEGMENT_KEY=null
 SITE_NAME='edX'

diff --git a/.env.test b/.env.test
@@ -11,7 +11,6 @@ LOGIN_URL='http://localhost:18000/login'
 LOGOUT_URL='http://localhost:18000/logout'
 MARKETING_SITE_BASE_URL='http://localhost:18000'
 ORDER_HISTORY_URL='localhost:1996/orders'
-RECORDS_BASE_URL='localhost:1990'
 REFRESH_ACCESS_TOKEN_ENDPOINT='http://localhost:18000/login_refresh'
 SEGMENT_KEY=null
 SITE_NAME='edX'

diff --git a/src/index.jsx b/src/index.jsx
@@ -22,7 +22,6 @@ import './index.scss';
 
 mergeConfig({
   LICENSE_MANAGER_URL: process.env.LICENSE_MANAGER_URL,
-  RECORDS_BASE_URL: process.env.RECORDS_BASE_URL,
   USE_LEARNER_RECORD_TAB: process.env.USE_LEARNER_RECORD_TAB,
 });
 

diff --git a/src/setupTest.js b/src/setupTest.js
@@ -9,7 +9,6 @@ Enzyme.configure({ adapter: new Adapter() });
 
 mergeConfig({
   LICENSE_MANAGER_URL: process.env.LICENSE_MANAGER_URL,
-  RECORDS_BASE_URL: process.env.RECORDS_BASE_URL,
   USE_LEARNER_RECORD_TAB: process.env.USE_LEARNER_RECORD_TAB,
 });
 

diff --git a/src/users/LearnerRecords.jsx b/src/users/LearnerRecords.jsx
@@ -11,7 +11,7 @@ import messages from './messages';
 function LearnerRecords({ username, intl }) {
   const [records, setRecords] = useState(null);
   const [error, setError] = useState(null);
-  const { RECORDS_BASE_URL } = getConfig();
+  const { CREDENTIALS_BASE_URL } = getConfig();
 
   useEffect(() => {
     if (username) {
@@ -26,7 +26,7 @@ function LearnerRecords({ username, intl }) {
   }, [username]);
 
   const handleCopyButton = (uuid) => {
-    navigator.clipboard.writeText(`${RECORDS_BASE_URL}/shared/${uuid}`);
+    navigator.clipboard.writeText(`${CREDENTIALS_BASE_URL}/records/programs/shared/${uuid}`);
   };
 
   const renderStatus = (program) => {