Skip to content

Commit

Permalink
Merge pull request #390 from openedx/jkantor/conflictError
Browse files Browse the repository at this point in the history
fix: error code expecting wrong data shape
  • Loading branch information
jansenk authored Mar 5, 2025
2 parents f87d521 + ebca59a commit 7aee856
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions src/data/redux/grading/reducer.js
Original file line number Diff line number Diff line change
Expand Up @@ -182,11 +182,11 @@ const grading = createSlice({

const gradeData = {
...state.gradeData,
...(payload && { [submissionUUID]: payload.submissionStatus.gradeData }),
...(payload && { [submissionUUID]: payload.gradeData }),
};

const { gradeStatus } = payload ? payload.submissionStatus : state.current;
const lockStatus = payload ? payload.submissionStatus.lockStatus : lockStatuses.unlocked;
const { gradeStatus } = payload || state.current;
const lockStatus = payload ? payload.lockStatus : lockStatuses.unlocked;

return {
...state,
Expand Down
2 changes: 1 addition & 1 deletion src/data/redux/grading/reducer.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,7 @@ describe('app reducer', () => {
});
describe('stopGrading', () => {
let output;
const args = { submissionStatus: { gradeData: testData, lockStatus, gradeStatus } };
const args = { gradeData: testData, lockStatus, gradeStatus };
describe('resulting state', () => {
test('gradingData: deletes current data', () => {
output = reducer(testState, actions.stopGrading());
Expand Down

0 comments on commit 7aee856

Please sign in to comment.