fix: resolve blip of UI before notices redirect, refactor NProgress loader #993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamstankiewicz
commented
Mar 5, 2024
| @@ -56,6 +37,10 @@ const Root = () => { | |||
| ); | |||
| } | |||
|
|
|||
| if (!isAppDataHydrated) { | |||
There was a problem hiding this comment.
[inform] Accounts for both user profile hydration and whether there's a notices redirect.
adamstankiewicz
changed the title
adamstankiewicz
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feat/react-query-route-loaders #993 +/- ##
==================================================================
+ Coverage 81.25% 81.40% +0.14%
==================================================================
Files 371 374 +3
Lines 7773 7792 +19
Branches 1888 1893 +5
==================================================================
+ Hits 6316 6343 +27
+ Misses 1401 1393 -8
Partials 56 56 ☔ View full report in Codecov by Sentry. |
brobro10000
approved these changes
Mar 6, 2024
adamstankiewicz
merged commit bc2a7a0
into
feat/react-query-route-loaders
7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For all changes
Only if submitting a visual change