Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: mark course about page static strings for i18n #991

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

jajjibhai008
Copy link
Contributor

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

@jajjibhai008 jajjibhai008 force-pushed the eahmadjaved/ENT-8340 branch from 27efaea to fe890e5 Compare March 5, 2024 12:00
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 84.64%. Comparing base (d36b78a) to head (5332058).
Report is 169 commits behind head on master.

Files Patch % Lines
.../course/course-header/deprecated/CourseRunCard.jsx 83.33% 2 Missing ⚠️
src/components/course/CourseSkills.jsx 0.00% 1 Missing ⚠️
...c/components/course/course-header/CourseHeader.jsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #991      +/-   ##
==========================================
- Coverage   84.87%   84.64%   -0.23%     
==========================================
  Files         320      342      +22     
  Lines        6399     7490    +1091     
  Branches     1552     1844     +292     
==========================================
+ Hits         5431     6340     +909     
- Misses        941     1112     +171     
- Partials       27       38      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@muhammad-ammar muhammad-ammar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Work. Left some minor comments to regarding updating the descriptions to add more context and some refactoring.

src/components/course/CourseMainContent.jsx Outdated Show resolved Hide resolved
src/components/course/CourseReview.jsx Outdated Show resolved Hide resolved
src/components/course/data/hooks.jsx Show resolved Hide resolved
src/components/course/data/hooks.jsx Show resolved Hide resolved
src/components/course/data/hooks.jsx Show resolved Hide resolved
@jajjibhai008 jajjibhai008 force-pushed the eahmadjaved/ENT-8340 branch from 3362e3c to 5332058 Compare March 7, 2024 09:57
@jajjibhai008 jajjibhai008 changed the title [WIP]feat: mark course about page static strings for i18n feat: mark course about page static strings for i18n Mar 7, 2024
@jajjibhai008 jajjibhai008 merged commit fabe08b into master Mar 7, 2024
7 checks passed
@jajjibhai008 jajjibhai008 deleted the eahmadjaved/ENT-8340 branch March 7, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants