Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adds check for isMarketableExternal to course run filter #1264

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

brobro10000
Copy link
Member

Adds a check to the isMarketableExternal flag to the standardAvailableCourseRunsFilter

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)
  • Ensure English strings are marked for translation. See documentation for more details.

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

@brobro10000 brobro10000 marked this pull request as ready for review January 29, 2025 21:41
Copy link
Contributor

@pwnage101 pwnage101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add test cases to this maybe?

Copy link
Contributor

@pwnage101 pwnage101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM - only non-blocking suggestion to add test cases.

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.47%. Comparing base (f62618a) to head (a838df7).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1264   +/-   ##
=======================================
  Coverage   89.47%   89.47%           
=======================================
  Files         404      404           
  Lines        8741     8741           
  Branches     2069     2117   +48     
=======================================
  Hits         7821     7821           
+ Misses        884      883    -1     
- Partials       36       37    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brobro10000 brobro10000 merged commit 082b9e6 into master Jan 29, 2025
6 checks passed
@brobro10000 brobro10000 deleted the hu/ent-is-marketable-external-2 branch January 29, 2025 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants