fix: call createAppRouter within App component; implement shouldRevalidate for rootLoader sub-route navigation
#1256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1256 +/- ##
==========================================
+ Coverage 89.25% 89.46% +0.21%
==========================================
Files 405 404 -1
Lines 8737 8735 -2
Branches 2064 2110 +46
==========================================
+ Hits 7798 7815 +17
+ Misses 903 884 -19
Partials 36 36 ☔ View full report in Codecov by Sentry. |
adamstankiewicz
force-pushed
the
ags/router-fix
branch
from
6646469 to
59cb844
Compare
adamstankiewicz
changed the title
createAppRouter within App component; implement shouldRevalidate for rootLoader sub-route navigation
brobro10000
approved these changes
Jan 23, 2025
| @@ -8,7 +8,7 @@ import { getRoutes } from '../../../routes'; | |||
| * @param {Object} queryClient React Query query client. | |||
| * @returns {Object} React Router browser router. | |||
| */ | |||
| export default function createAppRouter(queryClient: Types.QueryClient) { | |||
| export default function createAppRouter(queryClient: Types.QueryClient): Types.Router { | |||
There was a problem hiding this comment.
This defines an expected output type I am guessing?
There was a problem hiding this comment.
Correct, the added : Types.Router is telling TypeScript the createAppRouter function returns a value with the type Types.Router (which is technically a RemixRouter, same type as returned by createBrowserRouter and createMemoryRouter).
| AppProvider: ({ children }) => <div data-testid="app-provider">{children}</div>, | ||
| })); | ||
|
|
||
| describe('App', () => { |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ENT-9930
It was observed that when replicating an tangentially related issue, there was a brief usage of dispatching an error via
NewRelicLoggingServicebefore sending similar error via the expectedDatadogLoggingService. This brief usage ofNewRelicLoggingServicemay have caused errant reporting of some errors occurring within the React Router route loaders.This line was missed during the New Relic -> Datadog migration, and unfortunately
getConfig().loggingService(representingDatadogLoggingService) is not available here.This led to this PR removing the need to call
configureLoggingorconfigureAuthfor the purpose of the route loaders by moving creation of the aboveconst router = createAppRouter(queryClient)into the rendering of theApp, instead of at file import.The PR also removes a parent
Suspenseand its fallback componentAppSuspenseFallbackto make suspense issues more obvious at runtime during development.For all changes
Only if submitting a visual change