Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure consistency around start dates on course run cards in Course page #1203

Merged
merged 3 commits into from
Oct 3, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: remove stale comment
adamstankiewicz committed Oct 3, 2024
commit d9cb42e7684e07679ec85745b2e7d794d6be3f3f
4 changes: 0 additions & 4 deletions src/components/app/routes/loaders/rootLoader.ts
Original file line number Diff line number Diff line change
@@ -39,10 +39,6 @@ const makeRootLoader: Types.MakeRouteLoaderFunctionWithQueryClient = function ma
return null;
}

// TODO:
// - Make POST request to new onboarding API in enterprise-access (passing lms_user_id and enterprise_customer_uuid)
// - Remove `ensureActiveEnterpriseCustomerUser`, since it'll be abstracted in above API call.

// Ensure the active enterprise customer user is updated, when applicable (e.g., the
// current enterprise slug in the URL does not match the active enterprise customer's slug).
const updateActiveEnterpriseCustomerUserResult = await ensureActiveEnterpriseCustomerUser({

Unchanged files with check annotations Beta

import { MOCK_COURSE_RUN_START } from './constants';
import useCourseRunCardHeading from '../useCourseRunCardHeading';
import { COURSE_PACING_MAP } from '../../../../data/constants';
import dayjs from 'dayjs';

Check failure on line 11 in src/components/course/course-header/data/hooks/tests/useCourseRunCardHeading.test.jsx

GitHub Actions / tests

`dayjs` import should occur before import of `../../../../data/utils`
import { DATE_FORMAT } from '../../constants';
jest.mock('../../../../data/utils', () => ({