-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: mark course about page static strings for i18n #991
Conversation
27efaea
to
fe890e5
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #991 +/- ##
==========================================
- Coverage 84.87% 84.64% -0.23%
==========================================
Files 320 342 +22
Lines 6399 7490 +1091
Branches 1552 1844 +292
==========================================
+ Hits 5431 6340 +909
- Misses 941 1112 +171
- Partials 27 38 +11 ☔ View full report in Codecov by Sentry. |
fe890e5
to
3362e3c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great Work. Left some minor comments to regarding updating the descriptions to add more context and some refactoring.
src/components/course/course-header/deprecated/CourseRunCard.jsx
Outdated
Show resolved
Hide resolved
src/components/course/course-header/deprecated/CourseRunCard.jsx
Outdated
Show resolved
Hide resolved
3362e3c
to
5332058
Compare
For all changes
Only if submitting a visual change