Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hidden remove button #1600

Merged
merged 2 commits into from
Jan 24, 2025
Merged

Conversation

KristinAoki
Copy link
Member

Description

This PR fixes the visibility of the "Remove" button for grade segments. Previously, the button would appear on hover above the segment. But the styling of the button blocked it from being visible. Now, the button appears on hover under the grade range. This change impacts Course Authors.

Before

Screenshot 2025-01-21 at 2 08 39 PM

After

Screenshot 2025-01-21 at 2 08 49 PM

Testing instructions

  1. Open a course
  2. Navigate to the grading page
  3. Add a new grade
  4. Hover over new grade
  5. Confirm that "Remove" is visible
  6. Click "Remove"
  7. Confirm that the segment is removed

@KristinAoki KristinAoki requested a review from a team as a code owner January 21, 2025 19:22
@KristinAoki KristinAoki enabled auto-merge (squash) January 21, 2025 19:27
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.25%. Comparing base (13b2ed5) to head (445c998).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1600   +/-   ##
=======================================
  Coverage   93.25%   93.25%           
=======================================
  Files        1100     1100           
  Lines       21794    21794           
  Branches     4702     4701    -1     
=======================================
  Hits        20323    20323           
  Misses       1399     1399           
  Partials       72       72           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@saadyousafarbi saadyousafarbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good! Thanks for the fix!

@KristinAoki KristinAoki merged commit 2102c7a into master Jan 24, 2025
7 checks passed
@KristinAoki KristinAoki deleted the KristinAoki/fix-grade-segment-remove branch January 24, 2025 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants