-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add existing content to a collection [FC-0062] #1416
feat: add existing content to a collection [FC-0062] #1416
Conversation
Thanks for the pull request, @rpenido! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
e71fd44
to
21423e3
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1416 +/- ##
=======================================
Coverage 93.15% 93.15%
=======================================
Files 1051 1053 +2
Lines 20328 20373 +45
Branches 4335 4342 +7
=======================================
+ Hits 18936 18979 +43
+ Misses 1332 1331 -1
- Partials 60 63 +3 ☔ View full report in Codecov by Sentry. |
7f74d83
to
d45916d
Compare
bc45738
to
d612bd6
Compare
a7ce64b
to
9d9f3a1
Compare
12f9fe6
to
94ccd93
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Works beautifully @rpenido !
I'll see if I can help with the circular imports.
- I tested this on my dev stack using the PR test instructions
- I read through the code and tests
- I checked for accessibility issues by using my keyboard to navigate
- Includes documentation -- code comments
- User-facing strings are extracted for translation
6d5e25d
to
3fe699f
Compare
@rpenido Feel free to ping me if you are looking for a reviewer/merger on this one |
That would be awesome @kdmccormick! |
2f19728
to
806f32f
Compare
/** The component picker modal to use. We need to pass it as a reference instead of | ||
* directly importing it to avoid the import cycle: | ||
* ComponentPickerModal > ComponentPicker > LibraryAuthoringPage/LibraryCollectionPage > | ||
* Sidebar > AddContentContainer > ComponentPickerModal */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/** The component picker modal to use. We need to pass it as a reference instead of | |
* directly importing it to avoid the import cycle: | |
* ComponentPickerModal > ComponentPicker > LibraryAuthoringPage/LibraryCollectionPage > | |
* Sidebar > AddContentContainer > ComponentPickerModal */ | |
{/** The component picker modal to use. We need to pass it as a reference instead of | |
* directly importing it to avoid the import cycle:= | |
* ComponentPickerModal > ComponentPicker > LibraryAuthoringPage/LibraryCollectionPage > | |
* Sidebar > AddContentContainer > ComponentPickerModal */} |
My jsx is rusty, but doesn't this need to be in curly braces?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently it's not necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, works great!
@@ -51,6 +66,11 @@ const messages = defineMessages({ | |||
defaultMessage: 'There was an error creating the content.', | |||
description: 'Message when creation of content in library is on error', | |||
}, | |||
successAssociateComponentMessage: { | |||
id: 'course-authoring.library-authoring.associate-collection-content.success.text', | |||
defaultMessage: 'Content linked successfully.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure how I feel about using the term "linking" here, since it's very different than linking content to a course. No action needed now, just a potential place for refinement post-Sumac.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Description
This PR implements a feature that allows library components to be added to a collection using the add-content sidebar.
More information
Testing instruction
Private ref: FAL-3901}