feat: adding guard rails to content query association setter to prevent large negative deltas #829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-sheehan-edx
force-pushed
the
asheehan-edx/ENT-8778-content-query-association-guard-rails
branch
4 times, most recently
from
47cead6 to
18a6d80
Compare
marlonkeating
requested changes
May 9, 2024
Comment on lines
866
to
867
| f"content metadata set of length of {new_relations_size} when it previous had a content " | ||
| f"metadata set length of:{existing_relations_size}. The updated is prevented" |
There was a problem hiding this comment.
Could we log the percentage diff and the threshold we're working with?
There was a problem hiding this comment.
the percent dif is just new / old. But I'm fine with logging the threshold.
alex-sheehan-edx
force-pushed
the
asheehan-edx/ENT-8778-content-query-association-guard-rails
branch
2 times, most recently
from
349be9f to
e40c725
Compare
alex-sheehan-edx
force-pushed
the
asheehan-edx/ENT-8778-content-query-association-guard-rails
branch
2 times, most recently
from
f12f5ee to
727e8cd
Compare
marlonkeating
approved these changes
May 10, 2024
alex-sheehan-edx
force-pushed
the
asheehan-edx/ENT-8778-content-query-association-guard-rails
branch
from
727e8cd to
a4decba
Compare
iloveagent57
requested changes
May 10, 2024
|
|
||
| @override_settings(DISCOVERY_CATALOG_QUERY_CACHE_TIMEOUT=0) | ||
| @mock.patch('enterprise_catalog.apps.api_client.discovery.DiscoveryApiClient') | ||
| def test_associate_content_metadata_with_query_guardrails(self, mock_client): |
There was a problem hiding this comment.
great job on a thorough test!
alex-sheehan-edx
force-pushed
the
asheehan-edx/ENT-8778-content-query-association-guard-rails
branch
from
a4decba to
07d8d93
Compare
iloveagent57
approved these changes
May 10, 2024
alex-sheehan-edx
force-pushed
the
asheehan-edx/ENT-8778-content-query-association-guard-rails
branch
2 times, most recently
from
2ac6d18 to
11a15ab
Compare
…nt large negative deltas
alex-sheehan-edx
force-pushed
the
asheehan-edx/ENT-8778-content-query-association-guard-rails
branch
from
11a15ab to
f2e9eca
Compare
alex-sheehan-edx
deleted the
asheehan-edx/ENT-8778-content-query-association-guard-rails
branch
irfanuddinahmad
pushed a commit
that referenced
this pull request
Jul 24, 2024
…ery-association-guard-rails feat: adding guard rails to content query association setter to prevent large negative deltas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://2u-internal.atlassian.net/browse/ENT-8778
Post-review