Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: mark course as active in Agolia if is_marketable_external #1029

Merged
merged 2 commits into from
Jan 28, 2025
Merged

feat: mark course as active in Agolia if is_marketable_external #1029

merged 2 commits into from
Jan 28, 2025

Conversation

hamzawaleed01
Copy link
Member

@hamzawaleed01 hamzawaleed01 commented Jan 27, 2025 •
edited
Loading

Updated the utility functions to ensure that course runs with the is_marketable_external property set to True are indexed as active in Algolia. This change affects the logic in the is_course_run_active function, which now includes a check for the is_marketable_external property.

  • Squash commits into discrete sets of changes
  • Ensure that once the changes have been deployed to stage, prod is manually deployed

@hamzawaleed01 hamzawaleed01 force-pushed the ENT-9889/index-future-runs-algolia branch 4 times, most recently from fe08f97 to 2fcf167 Compare January 27, 2025 13:07
@hamzawaleed01 hamzawaleed01 force-pushed the ENT-9889/index-future-runs-algolia branch from 2fcf167 to 47e49b4 Compare January 27, 2025 13:19
@hamzawaleed01 hamzawaleed01 changed the title feat: mark course as active if is_marketable_external feat: mark course as active in Agolia if is_marketable_external Jan 27, 2025
sameeramin
sameeramin approved these changes Jan 27, 2025
View reviewed changes
Copy link
Contributor

@sameeramin sameeramin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

pwnage101
pwnage101 approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@pwnage101 pwnage101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non-blocking nits!

enterprise_catalog/apps/catalog/content_metadata_utils.py Outdated Show resolved Hide resolved
enterprise_catalog/apps/catalog/content_metadata_utils.py Outdated Show resolved Hide resolved
enterprise_catalog/apps/api/v1/utils.py Outdated Show resolved Hide resolved
@hamzawaleed01 hamzawaleed01 force-pushed the ENT-9889/index-future-runs-algolia branch from 8b06c1b to ea7d8c7 Compare January 28, 2025 08:43
@hamzawaleed01 hamzawaleed01 merged commit 8d2ab47 into master Jan 28, 2025
6 checks passed
@hamzawaleed01 hamzawaleed01 deleted the ENT-9889/index-future-runs-algolia branch January 28, 2025 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sameeramin sameeramin sameeramin approved these changes

@iloveagent57 iloveagent57 iloveagent57 approved these changes

@pwnage101 pwnage101 pwnage101 approved these changes

@adamstankiewicz adamstankiewicz Awaiting requested review from adamstankiewicz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hamzawaleed01 @pwnage101 @iloveagent57 @sameeramin