fix: set enrollment url course id to advertised course run key #1018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iloveagent57
reviewed
Jan 6, 2025
brobro10000
force-pushed
the
hu/ent-9865
branch
2 times, most recently
from
70fcc2d to
1f4c027
Compare
2 tasks
brobro10000
force-pushed
the
hu/ent-9865
branch
from
1f4c027 to
c388ef4
Compare
brobro10000
force-pushed
the
hu/ent-9865
branch
from
c388ef4 to
7851161
Compare
brobro10000
force-pushed
the
hu/ent-9865
branch
from
7851161 to
47fe738
Compare
brobro10000
force-pushed
the
hu/ent-9865
branch
from
47fe738 to
e675f09
Compare
enterprise_catalog/apps/catalog/tests/test_content_metadata_utils.py
Outdated
Show resolved
Hide resolved
brobro10000
force-pushed
the
hu/ent-9865
branch
2 times, most recently
from
e894f84 to
d0294ec
Compare
enterprise_catalog/apps/catalog/tests/test_content_metadata_utils.py
Outdated
Show resolved
Hide resolved
enterprise_catalog/apps/catalog/tests/test_content_metadata_utils.py
Outdated
Show resolved
Hide resolved
brobro10000
force-pushed
the
hu/ent-9865
branch
from
d0294ec to
8c4e891
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates how we set the enrollment url if the learner portal is not enabled. This is to fix an error that is manifesting in the LMS where the enrollment url is parsed for a course_id, but a top level course is retrieved. This breaks the expectation of what the OpaqueKeys
CourseKeyis expecting which includes a course run.The changes included ensures a course run is always passed within the enrollment url.
This is a root cause solution to this PR
Post-review